third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.h - Issue 2865903002: [LayoutNG] Inline margin/border/padding, inter-item breaking, and tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.h

Issue 2865903002: [LayoutNG] Inline margin/border/padding, inter-item breaking, and tests (Closed)

Patch Set: cbiesinger review Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item.cc ('k') | third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.cc » ('j') | third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.h

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.h b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.h

index 0e527708d8b34d3b98af7c6367f0852931aa722e..a81efcd4c4123b25e64ba2f126a936747bc45378 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.h

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.h

@@ -42,6 +42,14 @@ struct CORE_EXPORT NGInlineItemResult {

// NGBoxStrut for atomic inline items.

NGBoxStrut margins;

+ // Inside of this is not breakable.

+ // Used only during the line breaking.

ikilpatrick 2017/05/24 04:03:38 Used only during line breaking. (& below).

kojii 2017/05/24 15:50:55 Thank you, articles are not easy for me...

+ unsigned no_break_opportunities_inside : 1;

+ // Lines must not break after this.

+ // Used only during the line breaking.

+ unsigned prohibit_break_after : 1;

NGInlineItemResult();

NGInlineItemResult(unsigned index, unsigned start, unsigned end);

};