Make multiple calls to DialogOverlayImpl.close() do nothing.

Make multiple calls to DialogOverlayImpl.close() do nothing.

Previously, multiple calls to close() would result in multiple
notifications to AndroidOverlayProviderImpl.  It turns out that
onConnectionError is sometimes received after close().

This CL makes multiple calls to close() do nothing.

BUG=719181
TEST=DialogOverlayImplTest.testCloseOnlyClosesOnce

Review-Url: https://codereview.chromium.org/2865823003
Cr-Commit-Position: refs/heads/master@{#470079}
Committed: https://chromium.googlesource.com/chromium/src/+/2519704f857e56660e21c7309f8fdd18c86a8f99

[liberato (no reviews please), 2017-05-06 18:32:31]

The CQ bit was checked by liberato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-06 18:32:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-06 19:12:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-06 19:12:08]

Dry run: This issue passed the CQ dry run.

[liberato (no reviews please), 2017-05-08 16:53:04]

Description was changed from

==========
Make multiple calls to DialogOverlayImpl.close() do nothing.

Previously, multiple calls to close() would result in multiple
notifications to AndroidOverlayProviderImpl.  It turns out that
onConnectionError is sometimes received after close().

This CL makes multiple calls to close() do nothing.

BUG=719181
TEST=DialogOverlayImplTest.testCloseOnlyClosesOnce
==========

to

==========
Make multiple calls to DialogOverlayImpl.close() do nothing.

Previously, multiple calls to close() would result in multiple
notifications to AndroidOverlayProviderImpl.  It turns out that
onConnectionError is sometimes received after close().

This CL makes multiple calls to close() do nothing.

BUG=719181
TEST=DialogOverlayImplTest.testCloseOnlyClosesOnce
==========

[liberato (no reviews please), 2017-05-08 16:53:05]

liberato@chromium.org changed reviewers:
+ boliu@chromium.org

[liberato (no reviews please), 2017-05-08 16:54:31]

for fun, i thought that i might send you a CL that's smaller 2k lines :)

thanks
-fl

[boliu, 2017-05-08 18:22:16]

lgtm

[liberato (no reviews please), 2017-05-08 18:23:50]

The CQ bit was checked by liberato@chromium.org

[commit-bot: I haz the power, 2017-05-08 18:24:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 19:45:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494267830787070, "parent_rev":
"29948291955ddcd6c0cba23173c06e072585db29", "commit_rev":
"2519704f857e56660e21c7309f8fdd18c86a8f99"}

[commit-bot: I haz the power, 2017-05-08 19:45:54]

Description was changed from

==========
Make multiple calls to DialogOverlayImpl.close() do nothing.

Previously, multiple calls to close() would result in multiple
notifications to AndroidOverlayProviderImpl.  It turns out that
onConnectionError is sometimes received after close().

This CL makes multiple calls to close() do nothing.

BUG=719181
TEST=DialogOverlayImplTest.testCloseOnlyClosesOnce
==========

to

==========
Make multiple calls to DialogOverlayImpl.close() do nothing.

Previously, multiple calls to close() would result in multiple
notifications to AndroidOverlayProviderImpl.  It turns out that
onConnectionError is sometimes received after close().

This CL makes multiple calls to close() do nothing.

BUG=719181
TEST=DialogOverlayImplTest.testCloseOnlyClosesOnce

Review-Url: https://codereview.chromium.org/2865823003
Cr-Commit-Position: refs/heads/master@{#470079}
Committed:
https://chromium.googlesource.com/chromium/src/+/2519704f857e56660e21c7309f8f...
==========

[commit-bot: I haz the power, 2017-05-08 19:45:55]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2519704f857e56660e21c7309f8f...