Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2865793003: Fix GeolocationSettingsDialogBackOff histograms enum (Closed)

Created:
3 years, 7 months ago by benwells
Modified:
3 years, 7 months ago
Reviewers:
raymes
CC:
chromium-reviews, asvitkine+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GeolocationSettingsDialogBackOff histograms enum The enum is out of sync with the code, which has an extra value. BUG=703493 Review-Url: https://codereview.chromium.org/2865793003 Cr-Commit-Position: refs/heads/master@{#469928} Committed: https://chromium.googlesource.com/chromium/src/+/b19c6575a331d41e4fcc6dc742d2abcfebc0430e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M tools/metrics/histograms/enums.xml View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
benwells
3 years, 7 months ago (2017-05-06 07:42:18 UTC) #3
raymes
lgtm
3 years, 7 months ago (2017-05-07 21:53:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865793003/1
3 years, 7 months ago (2017-05-08 07:33:40 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 09:04:00 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b19c6575a331d41e4fcc6dc742d2...

Powered by Google App Engine
This is Rietveld 408576698