|
|
Description[Mac] Move the "Customize Touch Bar" Menu Item
Move the "Customize Touch Bar" menu item so that it's the third item in the
Views menu.
This is done by removing "setAutomaticCustomizeTouchBarMenuItemEnabled"
and manually adding the item in MainMenu.xib. AppKit will name and validate
the menu item, and hides it on systems that do not have a Touch Bar. However,
this is only available in 10.12.1+. We manually have to remove that item if
it's not supported.
See "The Customization Menu Item" section in the following link for more
details: https://developer.apple.com/reference/appkit/nstouchbar
BUG=716185
Review-Url: https://codereview.chromium.org/2865763002
Cr-Commit-Position: refs/heads/master@{#470641}
Committed: https://chromium.googlesource.com/chromium/src/+/bf3edb98a3b2787fcf36198f9fe9e5600db95dba
Patch Set 1 #Patch Set 2 : Cleaned up #
Messages
Total messages: 42 (34 generated)
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [Mac] Move the "Customize Touch Bar" Menu Item BUG=716185 ========== to ========== [Mac] Move the "Customize Touch Bar" Menu Item Move the "Customize Touch Bar" menu item so that it's the third item in the Views menu. This is done by removing "setAutomaticCustomizeTouchBarMenuItemEnabled" and manually adding the item in MainMenu.xib. BUG=716185 ==========
Description was changed from ========== [Mac] Move the "Customize Touch Bar" Menu Item Move the "Customize Touch Bar" menu item so that it's the third item in the Views menu. This is done by removing "setAutomaticCustomizeTouchBarMenuItemEnabled" and manually adding the item in MainMenu.xib. BUG=716185 ========== to ========== [Mac] Move the "Customize Touch Bar" Menu Item Move the "Customize Touch Bar" menu item so that it's the third item in the Views menu. This is done by removing "setAutomaticCustomizeTouchBarMenuItemEnabled" and manually adding the item in MainMenu.xib. AppKit will name and validate the menu item, and hides it on systems that do not have a Touch Bar. However, this is only available in 10.12.1+. We manually have to remove that item if it's not supported. See "The Customization Menu Item" section in the following link for more details: https://developer.apple.com/reference/appkit/nstouchbar BUG=716185 ==========
spqchan@chromium.org changed reviewers: + avi@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [Mac] Move the "Customize Touch Bar" Menu Item Move the "Customize Touch Bar" menu item so that it's the third item in the Views menu. This is done by removing "setAutomaticCustomizeTouchBarMenuItemEnabled" and manually adding the item in MainMenu.xib. AppKit will name and validate the menu item, and hides it on systems that do not have a Touch Bar. However, this is only available in 10.12.1+. We manually have to remove that item if it's not supported. See "The Customization Menu Item" section in the following link for more details: https://developer.apple.com/reference/appkit/nstouchbar BUG=716185 ========== to ========== [Mac] Move the "Customize Touch Bar" Menu Item Move the "Customize Touch Bar" menu item so that it's the third item in the Views menu. This is done by removing "setAutomaticCustomizeTouchBarMenuItemEnabled" and manually adding the item in MainMenu.xib. AppKit will name and validate the menu item, and hides it on systems that do not have a Touch Bar. However, this is only available in 10.12.1+. We manually have to remove that item if it's not supported. See "The Customization Menu Item" section in the following link for more details: https://developer.apple.com/reference/appkit/nstouchbar BUG=716185 ==========
Description was changed from ========== [Mac] Move the "Customize Touch Bar" Menu Item Move the "Customize Touch Bar" menu item so that it's the third item in the Views menu. This is done by removing "setAutomaticCustomizeTouchBarMenuItemEnabled" and manually adding the item in MainMenu.xib. AppKit will name and validate the menu item, and hides it on systems that do not have a Touch Bar. However, this is only available in 10.12.1+. We manually have to remove that item if it's not supported. See "The Customization Menu Item" section in the following link for more details: https://developer.apple.com/reference/appkit/nstouchbar BUG=716185 ========== to ========== [Mac] Move the "Customize Touch Bar" Menu Item Move the "Customize Touch Bar" menu item so that it's the third item in the Views menu. This is done by removing "setAutomaticCustomizeTouchBarMenuItemEnabled" and manually adding the item in MainMenu.xib. AppKit will name and validate the menu item, and hides it on systems that do not have a Touch Bar. However, this is only available in 10.12.1+. We manually have to remove that item if it's not supported. See "The Customization Menu Item" section in the following link for more details: https://developer.apple.com/reference/appkit/nstouchbar BUG=716185 ==========
Description was changed from ========== [Mac] Move the "Customize Touch Bar" Menu Item Move the "Customize Touch Bar" menu item so that it's the third item in the Views menu. This is done by removing "setAutomaticCustomizeTouchBarMenuItemEnabled" and manually adding the item in MainMenu.xib. AppKit will name and validate the menu item, and hides it on systems that do not have a Touch Bar. However, this is only available in 10.12.1+. We manually have to remove that item if it's not supported. See "The Customization Menu Item" section in the following link for more details: https://developer.apple.com/reference/appkit/nstouchbar BUG=716185 ========== to ========== [Mac] Move the "Customize Touch Bar" Menu Item Move the "Customize Touch Bar" menu item so that it's the third item in the Views menu. This is done by removing "setAutomaticCustomizeTouchBarMenuItemEnabled" and manually adding the item in MainMenu.xib. AppKit will name and validate the menu item, and hides it on systems that do not have a Touch Bar. However, this is only available in 10.12.1+. We manually have to remove that item if it's not supported. See "The Customization Menu Item" section in the following link for more details: https://developer.apple.com/reference/appkit/nstouchbar BUG=716185 ==========
Description was changed from ========== [Mac] Move the "Customize Touch Bar" Menu Item Move the "Customize Touch Bar" menu item so that it's the third item in the Views menu. This is done by removing "setAutomaticCustomizeTouchBarMenuItemEnabled" and manually adding the item in MainMenu.xib. AppKit will name and validate the menu item, and hides it on systems that do not have a Touch Bar. However, this is only available in 10.12.1+. We manually have to remove that item if it's not supported. See "The Customization Menu Item" section in the following link for more details: https://developer.apple.com/reference/appkit/nstouchbar BUG=716185 ========== to ========== [Mac] Move the "Customize Touch Bar" Menu Item Move the "Customize Touch Bar" menu item so that it's the third item in the Views menu. This is done by removing "setAutomaticCustomizeTouchBarMenuItemEnabled" and manually adding the item in MainMenu.xib. AppKit will name and validate the menu item, and hides it on systems that do not have a Touch Bar. However, this is only available in 10.12.1+. We manually have to remove that item if it's not supported. See "The Customization Menu Item" section in the following link for more details: https://developer.apple.com/reference/appkit/nstouchbar BUG=716185 ==========
Description was changed from ========== [Mac] Move the "Customize Touch Bar" Menu Item Move the "Customize Touch Bar" menu item so that it's the third item in the Views menu. This is done by removing "setAutomaticCustomizeTouchBarMenuItemEnabled" and manually adding the item in MainMenu.xib. AppKit will name and validate the menu item, and hides it on systems that do not have a Touch Bar. However, this is only available in 10.12.1+. We manually have to remove that item if it's not supported. See "The Customization Menu Item" section in the following link for more details: https://developer.apple.com/reference/appkit/nstouchbar BUG=716185 ========== to ========== [Mac] Move the "Customize Touch Bar" Menu Item Move the "Customize Touch Bar" menu item so that it's the third item in the Views menu. This is done by removing "setAutomaticCustomizeTouchBarMenuItemEnabled" and manually adding the item in MainMenu.xib. AppKit will name and validate the menu item, and hides it on systems that do not have a Touch Bar. However, this is only available in 10.12.1+. We manually have to remove that item if it's not supported. See "The Customization Menu Item" section in the following link for more details: https://developer.apple.com/reference/appkit/nstouchbar BUG=716185 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:20001) has been deleted
Patchset #2 (id:40001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL
lgtm
spqchan@chromium.org changed reviewers: + thakis@chromium.org
Thanks! +thakis for chrome/app/chrome_command_ids.h
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
On 2017/05/08 23:56:48, spqchan wrote: > Thanks! > > +thakis for chrome/app/chrome_command_ids.h ping on the issue
lgtm
On 2017/05/10 16:01:32, Nico wrote: > lgtm thanks!
The CQ bit was checked by spqchan@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494432168319880, "parent_rev": "c9079413f6fdd2320ebd14f13db182910a9229b1", "commit_rev": "bf3edb98a3b2787fcf36198f9fe9e5600db95dba"}
Message was sent while issue was closed.
Description was changed from ========== [Mac] Move the "Customize Touch Bar" Menu Item Move the "Customize Touch Bar" menu item so that it's the third item in the Views menu. This is done by removing "setAutomaticCustomizeTouchBarMenuItemEnabled" and manually adding the item in MainMenu.xib. AppKit will name and validate the menu item, and hides it on systems that do not have a Touch Bar. However, this is only available in 10.12.1+. We manually have to remove that item if it's not supported. See "The Customization Menu Item" section in the following link for more details: https://developer.apple.com/reference/appkit/nstouchbar BUG=716185 ========== to ========== [Mac] Move the "Customize Touch Bar" Menu Item Move the "Customize Touch Bar" menu item so that it's the third item in the Views menu. This is done by removing "setAutomaticCustomizeTouchBarMenuItemEnabled" and manually adding the item in MainMenu.xib. AppKit will name and validate the menu item, and hides it on systems that do not have a Touch Bar. However, this is only available in 10.12.1+. We manually have to remove that item if it's not supported. See "The Customization Menu Item" section in the following link for more details: https://developer.apple.com/reference/appkit/nstouchbar BUG=716185 Review-Url: https://codereview.chromium.org/2865763002 Cr-Commit-Position: refs/heads/master@{#470641} Committed: https://chromium.googlesource.com/chromium/src/+/bf3edb98a3b2787fcf36198f9fe9... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as https://chromium.googlesource.com/chromium/src/+/bf3edb98a3b2787fcf36198f9fe9... |