Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2865763002: [Mac] Move the "Customize Touch Bar" Menu Item (Closed)

Created:
3 years, 7 months ago by spqchan
Modified:
3 years, 7 months ago
Reviewers:
Avi (use Gerrit), Nico
CC:
chromium-reviews, srahim+watch_chromium.org, danakj+watch_chromium.org, mac-reviews_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Move the "Customize Touch Bar" Menu Item Move the "Customize Touch Bar" menu item so that it's the third item in the Views menu. This is done by removing "setAutomaticCustomizeTouchBarMenuItemEnabled" and manually adding the item in MainMenu.xib. AppKit will name and validate the menu item, and hides it on systems that do not have a Touch Bar. However, this is only available in 10.12.1+. We manually have to remove that item if it's not supported. See "The Customization Menu Item" section in the following link for more details: https://developer.apple.com/reference/appkit/nstouchbar BUG=716185 Review-Url: https://codereview.chromium.org/2865763002 Cr-Commit-Position: refs/heads/master@{#470641} Committed: https://chromium.googlesource.com/chromium/src/+/bf3edb98a3b2787fcf36198f9fe9e5600db95dba

Patch Set 1 #

Patch Set 2 : Cleaned up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M base/mac/sdk_forward_declarations.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/app/chrome_command_ids.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/app/nibs/MainMenu.xib View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/app_controller_mac.mm View 1 2 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 42 (34 generated)
spqchan
PTAL
3 years, 7 months ago (2017-05-08 23:40:20 UTC) #29
Avi (use Gerrit)
lgtm
3 years, 7 months ago (2017-05-08 23:45:32 UTC) #30
spqchan
Thanks! +thakis for chrome/app/chrome_command_ids.h
3 years, 7 months ago (2017-05-08 23:56:48 UTC) #32
spqchan
On 2017/05/08 23:56:48, spqchan wrote: > Thanks! > > +thakis for chrome/app/chrome_command_ids.h ping on the ...
3 years, 7 months ago (2017-05-10 00:06:01 UTC) #35
Nico
lgtm
3 years, 7 months ago (2017-05-10 16:01:32 UTC) #36
spqchan
On 2017/05/10 16:01:32, Nico wrote: > lgtm thanks!
3 years, 7 months ago (2017-05-10 16:02:41 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865763002/60001
3 years, 7 months ago (2017-05-10 16:04:02 UTC) #39
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 18:01:34 UTC) #42
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bf3edb98a3b2787fcf36198f9fe9...

Powered by Google App Engine
This is Rietveld 408576698