Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2865703002: Remove LayerTreeHostImpl::DrawViewportSize(). (Closed)

Created:
3 years, 7 months ago by danakj
Modified:
3 years, 7 months ago
Reviewers:
Saman Sami, enne (OOO)
CC:
enne (OOO), boliu, cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove LayerTreeHostImpl::DrawViewportSize(). This method used to have some logic in it, but is now just the size of the DeviceViewport(). So have callers use that directly to reduce the API surface. R=samans@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2865703002 Cr-Commit-Position: refs/heads/master@{#469720} Committed: https://chromium.googlesource.com/chromium/src/+/914d3011abd8040a608aa533781c1ce6bbc40399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -37 lines) Patch
M cc/output/bsp_tree_perftest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_common_perftest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 2 chunks +4 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 4 chunks +9 lines, -13 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_impl.cc View 3 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
danakj
3 years, 7 months ago (2017-05-05 15:11:39 UTC) #2
enne (OOO)
lgtm
3 years, 7 months ago (2017-05-05 17:04:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865703002/1
3 years, 7 months ago (2017-05-05 17:58:07 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 18:08:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/914d3011abd8040a608aa533781c...

Powered by Google App Engine
This is Rietveld 408576698