X509NameAttribute::ValueAsString: Decode TeletexString as Latin1.

net/cert/internal/parse_name.cc

Index: net/cert/internal/parse_name.cc
diff --git a/net/cert/internal/parse_name.cc b/net/cert/internal/parse_name.cc
index d9eaaeed7c86f25de361e8d5f5804f892294a879..ec3277bd3f69d76f515a126e40e3e0d51f68277b 100644
--- a/net/cert/internal/parse_name.cc
+++ b/net/cert/internal/parse_name.cc
@@ -12,6 +12,10 @@
 #include "base/sys_byteorder.h"
 #include "base/third_party/icu/icu_utf.h"
 
+#if !defined(OS_NACL)
+#include "net/base/net_string_util.h"
+#endif
+
 namespace net {
 
 namespace {
@@ -192,12 +196,11 @@ der::Input TypeDomainComponentOid() {
 bool X509NameAttribute::ValueAsString(std::string* out) const {
   switch (value_tag) {
     case der::kTeletexString:
-      for (char c : value.AsStringPiece()) {
-        if (c < 32 || c > 126)
-          return false;
-      }
-      *out = value.AsString();
-      return true;
+#if !defined(OS_NACL)
+      return ConvertToUtf8(value.AsString(), kCharsetLatin1, out);
+#else
+// For nacl, just fall through to treating like IA5String (ascii).

[eroman, 2017/05/05 17:55:29]

Why the difference for  nacl?

[mattm, 2017/05/05 19:58:39]

the net/ build for nacl doesn't include base/net_string_util_icu.cc or the
//base:i18n and //third_party/icu deps. It looks like nacl actually does depend
on ICU through other chains, but simply adding the deps in net and using the
ConvertToUtf8 increased newlib_pnacl/remoting_client_plugin_newlib.pexe by 100KB
(release build).

Given David's comment on https://codereview.chromium.org/2861813002/ I don't
think nacl will care about this. So I don't really like making this difference,
but I was thinking it's probably not worth increasing nacl build size by 100KB.

[eroman, 2017/05/05 20:07:07]

It is unfortunate to have a different behavior here, should it ever grow more
dependencies on this.

Can you add a comment explaining this, and perhaps a TODO as well?

[mattm, 2017/05/05 20:16:25]

Done.

[davidben, 2017/05/12 16:47:26]

FWIW, Latin1 doesn't need much code to convert to UTF-8:

out->clear();
size_t len = value.Length();
for (char c : value.AsStringPiece()) {
  if (static_cast<uint8_t>(c) > 0x7f)
    len++;
}
out->reserve(len);
for (char c : value.AsStringPiece()) {
  uint8_t u = static_cast<uint8_t>(c);
  if (u > 0x7f) {
    out->push_back(0xc0 | (u >> 6));
    out->push_back(0x80 | (u & 0x3f));
  } else {
    out->push_back(u);
  }
}
DCHECK_EQ(len, out->size());

+#endif
     case der::kIA5String:
       for (char c : value.AsStringPiece()) {
         if (static_cast<uint8_t>(c) > 127)