Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2861813002: Switch NaCl to use_byte_certs. (Closed)

Created:
3 years, 7 months ago by davidben
Modified:
3 years, 7 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch NaCl to use_byte_certs. The NaCl build (used by //remoting) doesn't actually process certificates, so we can switch them easily. (They configure SSLClientSocket to allow only a single certificate and run some other authenticator over the channel.) Sadly, this doesn't buy the binary size wins yet. It looks like this is because they pull in WebRTC. But it means that once this and the Android switch sticks, we can tidy up USE_OPENSSL_CERTS. BUG=671420 Review-Url: https://codereview.chromium.org/2861813002 Cr-Commit-Position: refs/heads/master@{#469213} Committed: https://chromium.googlesource.com/chromium/src/+/7c97df67012325269eaf4a3f627e442f47266bbb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M net/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
davidben
3 years, 7 months ago (2017-05-03 19:35:15 UTC) #4
mattm
lgtm
3 years, 7 months ago (2017-05-03 19:53:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861813002/1
3 years, 7 months ago (2017-05-04 00:12:10 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 00:22:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7c97df67012325269eaf4a3f627e...

Powered by Google App Engine
This is Rietveld 408576698