[codesearch] Add codesearch chromium gen args to mb_config

[codesearch] Add codesearch chromium gen args to mb_config

Will use mb for gn args of chromium_codesearch.py. Add gn configs in
mb_config.pyl
(https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave/recipes/chromium_codesearch.py#49)

BUG=718658
Review-Url: https://codereview.chromium.org/2865593002
Cr-Commit-Position: refs/heads/master@{#469577}
Committed: https://chromium.googlesource.com/chromium/src/+/6bd1fc8a43faee33e11dafd0b9e62e0533ee3324

[shenghuazhang, 2017-05-05 00:12:53]

shenghuazhang@chromium.org changed reviewers:
+ jbudorick@chromium.org, mikecase@chromium.org

[jbudorick, 2017-05-05 00:36:33]

https://codereview.chromium.org/2865593002/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2865593002/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:1164: 'codesearch_gen_chromium_android_bot': [
All three of these should also use goma.

https://codereview.chromium.org/2865593002/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:1169: 'clang', 'shared', 'debug', 'minimal_symbols',
'x64', 'chromeos', 'gn_linux_upload',
I think it'd be better to use 'ozone' directly rather than 'gn_linux_upload';
from reading the comment in the latter, it seems like the ozone part is a hacky
workaround.

[shenghuazhang, 2017-05-05 00:52:35]

https://codereview.chromium.org/2865593002/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2865593002/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:1164: 'codesearch_gen_chromium_android_bot': [
On 2017/05/05 00:36:33, jbudorick wrote:
> All three of these should also use goma.

Done.

https://codereview.chromium.org/2865593002/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:1169: 'clang', 'shared', 'debug', 'minimal_symbols',
'x64', 'chromeos', 'gn_linux_upload',
On 2017/05/05 00:36:33, jbudorick wrote:
> I think it'd be better to use 'ozone' directly rather than 'gn_linux_upload';
> from reading the comment in the latter, it seems like the ozone part is a
hacky
> workaround.

Done. 
Yeah it seems to be, though probably should keep it for the chromiumos bot? The
good news is the new clankium codesearch gen bot won't need the ozone arg :P

[jbudorick, 2017-05-05 00:58:22]

lgtm

https://codereview.chromium.org/2865593002/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2865593002/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:1169: 'clang', 'shared', 'debug', 'minimal_symbols',
'x64', 'chromeos', 'gn_linux_upload',
On 2017/05/05 00:52:34, shenghuazhang wrote:
> On 2017/05/05 00:36:33, jbudorick wrote:
> > I think it'd be better to use 'ozone' directly rather than
'gn_linux_upload';
> > from reading the comment in the latter, it seems like the ozone part is a
> hacky
> > workaround.
> 
> Done. 
> Yeah it seems to be, though probably should keep it for the chromiumos bot?
The
> good news is the new clankium codesearch gen bot won't need the ozone arg :P

I don't think the ozone part is a hack, I think gn_linux_upload using ozone is a
hack. We should definitely keep ozone here.

[shenghuazhang, 2017-05-05 00:59:22]

https://codereview.chromium.org/2865593002/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2865593002/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:1169: 'clang', 'shared', 'debug', 'minimal_symbols',
'x64', 'chromeos', 'gn_linux_upload',
On 2017/05/05 00:58:22, jbudorick wrote:
> On 2017/05/05 00:52:34, shenghuazhang wrote:
> > On 2017/05/05 00:36:33, jbudorick wrote:
> > > I think it'd be better to use 'ozone' directly rather than
> 'gn_linux_upload';
> > > from reading the comment in the latter, it seems like the ozone part is a
> > hacky
> > > workaround.
> > 
> > Done. 
> > Yeah it seems to be, though probably should keep it for the chromiumos bot?
> The
> > good news is the new clankium codesearch gen bot won't need the ozone arg :P
> 
> I don't think the ozone part is a hack, I think gn_linux_upload using ozone is
a
> hack. We should definitely keep ozone here.

Acknowledged.

[shenghuazhang, 2017-05-05 00:59:29]

The CQ bit was checked by shenghuazhang@chromium.org

[commit-bot: I haz the power, 2017-05-05 00:59:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mikecase (-- gone --), 2017-05-05 01:07:44]

lgtm

[commit-bot: I haz the power, 2017-05-05 02:59:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493945969677530,
"parent_rev": "f197d9b5000564960a0b79babb804fad9c74aa01", "commit_rev":
"6bd1fc8a43faee33e11dafd0b9e62e0533ee3324"}

[commit-bot: I haz the power, 2017-05-05 02:59:39]

Description was changed from

==========
[codesearch] Add codesearch chromium gen args to mb_config

Will use mb for gn args of chromium_codesearch.py. Add gn configs in
mb_config.pyl
(https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave...)

BUG=718658
==========

to

==========
[codesearch] Add codesearch chromium gen args to mb_config

Will use mb for gn args of chromium_codesearch.py. Add gn configs in
mb_config.pyl
(https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave...)

BUG=718658

Review-Url: https://codereview.chromium.org/2865593002
Cr-Commit-Position: refs/heads/master@{#469577}
Committed:
https://chromium.googlesource.com/chromium/src/+/6bd1fc8a43faee33e11dafd0b9e6...
==========

[commit-bot: I haz the power, 2017-05-05 02:59:40]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6bd1fc8a43faee33e11dafd0b9e6...