Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2865573002: build: Fix optimize_for_size build on Linux by adding an is_nacl guard. (Closed)

Created:
3 years, 7 months ago by pcc1
Modified:
3 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

build: Fix optimize_for_size build on Linux by adding an is_nacl guard. The PNaCl compiler does not understand -Os. BUG=660216 R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2865573002 Cr-Commit-Position: refs/heads/master@{#469552} Committed: https://chromium.googlesource.com/chromium/src/+/a367e903ff405e49e4a22b0512b8b989be08838a

Patch Set 1 #

Patch Set 2 : Add TODO to fix NaCl compiler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M build/config/compiler/BUILD.gn View 1 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
pcc1
3 years, 7 months ago (2017-05-04 23:04:17 UTC) #1
Nico
Lgtm, but can you file a bug for that and add a to-do pointing at ...
3 years, 7 months ago (2017-05-04 23:17:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865573002/20001
3 years, 7 months ago (2017-05-04 23:39:32 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 00:45:46 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a367e903ff405e49e4a22b0512b8...

Powered by Google App Engine
This is Rietveld 408576698