Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2865553002: Naming more views and windows to simplify debugging. (Closed)

Created:
3 years, 7 months ago by vadimt
Modified:
3 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, tfarina, Matt Giuca
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Naming more views and windows to simplify debugging. Bug=712331 Review-Url: https://codereview.chromium.org/2865553002 Cr-Commit-Position: refs/heads/master@{#469535} Committed: https://chromium.googlesource.com/chromium/src/+/b5affd8856bc45e32552223e5e41f7ae51a96220

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M chrome/browser/ui/app_list/search_answer_web_contents_delegate.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/app_list/views/app_list_view.cc View 2 chunks +1 line, -1 line 1 comment Download
M ui/app_list/views/contents_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/app_list/views/search_box_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/views/search_box_view.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/app_list/views/search_result_container_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/app_list/views/search_result_container_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/app_list/views/tile_item_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/views/tile_item_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
vadimt
3 years, 7 months ago (2017-05-04 22:33:57 UTC) #2
xiyuan
lgtm https://codereview.chromium.org/2865553002/diff/1/ui/app_list/views/app_list_view.cc File ui/app_list/views/app_list_view.cc (right): https://codereview.chromium.org/2865553002/diff/1/ui/app_list/views/app_list_view.cc#newcode379 ui/app_list/views/app_list_view.cc:379: search_box_widget_params.name = "SearchBoxView"; nit: SearchBoxView -> SearchBoxWidget to ...
3 years, 7 months ago (2017-05-04 23:08:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865553002/1
3 years, 7 months ago (2017-05-04 23:11:01 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 00:12:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b5affd8856bc45e32552223e5e41...

Powered by Google App Engine
This is Rietveld 408576698