Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2865503002: Mark SSLUITest.TestHTTPSErrorWithNoNavEntry as not flaky (Closed)

Created:
3 years, 7 months ago by meacer
Modified:
3 years, 7 months ago
Reviewers:
felt
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark SSLUITest.TestHTTPSErrorWithNoNavEntry as not flaky The flakes are from 2011 and don't seem to happen on local runs. Deflake the test. BUG=368280, 92292 Review-Url: https://codereview.chromium.org/2865503002 Cr-Commit-Position: refs/heads/master@{#469460} Committed: https://chromium.googlesource.com/chromium/src/+/1672250ece2bf96f487093d5b495848c8580fef2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M chrome/browser/ssl/ssl_browser_tests.cc View 2 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
meacer
Another one, ptal.
3 years, 7 months ago (2017-05-04 19:28:09 UTC) #4
felt
lgtm good luck
3 years, 7 months ago (2017-05-04 19:55:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865503002/1
3 years, 7 months ago (2017-05-04 20:45:00 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 20:52:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1672250ece2bf96f487093d5b495...

Powered by Google App Engine
This is Rietveld 408576698