Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreInfo.java

Issue 2865463003: Tracks GVR version crossed with headset type using UMA. (Closed)
Patch Set: Nit: only create native-Java enum if enable_vr is set Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreInfo.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreInfo.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreInfo.java
new file mode 100644
index 0000000000000000000000000000000000000000..c4e1cca661ef83ea5adf6f72d6d466d47a4fe512
--- /dev/null
+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreInfo.java
@@ -0,0 +1,22 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.vr_shell;
+
+import com.google.vr.ndk.base.Version;
+
+/**
+ * Container class to provide the version and the compatibility with Chromium of the installed
+ * VrCore.
+ */
+public class VrCoreInfo {
+ public final Version gvrVersion;
ddorwin 2017/05/24 07:31:37 nit: Since this class is GVR-specific, "gvr" may b
tiborg 2017/05/25 00:06:02 I wanted to communicate that this is the version o
+ @VrCoreCompatibility
+ public final int compatibility;
+
+ public VrCoreInfo(Version gvrVersion, int compatibility) {
+ this.gvrVersion = gvrVersion;
+ this.compatibility = compatibility;
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698