Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreInfo.java

Issue 2865463003: Tracks GVR version crossed with headset type using UMA. (Closed)
Patch Set: Nit: only create native-Java enum if enable_vr is set Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 package org.chromium.chrome.browser.vr_shell;
6
7 import com.google.vr.ndk.base.Version;
8
9 /**
10 * Container class to provide the version and the compatibility with Chromium of the installed
11 * VrCore.
12 */
13 public class VrCoreInfo {
14 public final Version gvrVersion;
ddorwin 2017/05/24 07:31:37 nit: Since this class is GVR-specific, "gvr" may b
tiborg 2017/05/25 00:06:02 I wanted to communicate that this is the version o
15 @VrCoreCompatibility
16 public final int compatibility;
17
18 public VrCoreInfo(Version gvrVersion, int compatibility) {
19 this.gvrVersion = gvrVersion;
20 this.compatibility = compatibility;
21 }
22 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698