Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2865453002: Run NonThreadSafeDeathTests in the threadsafe gtest mode. (Closed)

Created:
3 years, 7 months ago by Robert Sesek
Modified:
3 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Run NonThreadSafeDeathTests in the threadsafe gtest mode. On Mac, //base/threading uses CoreFoundation, which causes forked child processes to violate the framework's requirement that CF may not be used after-fork-before-exec. BUG=717490 R=mark@chromium.org Review-Url: https://codereview.chromium.org/2865453002 Cr-Commit-Position: refs/heads/master@{#469375} Committed: https://chromium.googlesource.com/chromium/src/+/b4704531f34265eb7fa58c2e08fa6435519f45ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M base/threading/non_thread_safe_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Robert Sesek
3 years, 7 months ago (2017-05-04 17:15:40 UTC) #5
Mark Mentovai
LGTM
3 years, 7 months ago (2017-05-04 17:34:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865453002/1
3 years, 7 months ago (2017-05-04 17:36:07 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 17:42:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b4704531f34265eb7fa58c2e08fa...

Powered by Google App Engine
This is Rietveld 408576698