Install FakeContextFactory for AuraMusWmTestBase

Install FakeContextFactory for AuraMusWmTestBase

Override AuraMusWmTestBase::SetUp() and TearDown() to use a FakeContextFactory
for its tests and restore the original ContextFactory to avoid affecting the
other tests.

Doing this allows WindowTreeHostMus to set accelerate_widget to a non-zero value
like it normally would. WindowTreeHostMus doesn't have to have a special case
for tests anymore.

BUG=717760
Review-Url: https://codereview.chromium.org/2865443002
Cr-Commit-Position: refs/heads/master@{#469741}
Committed: https://chromium.googlesource.com/chromium/src/+/89b9688d75599341703719d88b5f09841ac4d5de

[Alex Z., 2017-05-04 14:30:01]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 14:30:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alex Z., 2017-05-04 14:32:59]

staraz@chromium.org changed reviewers:
+ sadrul@chromium.org

[Alex Z., 2017-05-04 14:32:59]

PTAL.

[commit-bot: I haz the power, 2017-05-04 15:24:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 15:24:44]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-05-04 17:50:46]

https://codereview.chromium.org/2865443002/diff/1/ui/aura/test/aura_mus_test_...
File ui/aura/test/aura_mus_test_base.cc (right):

https://codereview.chromium.org/2865443002/diff/1/ui/aura/test/aura_mus_test_...
ui/aura/test/aura_mus_test_base.cc:21:
env->set_context_factory(&context_factory_);
I think you want to do this first, before seeing up AuraTestBase?

https://codereview.chromium.org/2865443002/diff/1/ui/aura/test/aura_mus_test_...
ui/aura/test/aura_mus_test_base.cc:35: set_window_manager_delegate(nullptr);
I think we should do this here too.

[Alex Z., 2017-05-04 18:00:59]

Description was changed from

==========
Install FakeContextFactory for AuraMusWmTestBase

Override AuraMusWmTestBase::SetUp() and TearDown() to use a FakeContextFactory
for its tests and restore the original ContextFactory to avoid affecting the
other tests.

Doing this allows WindowTreeHostMus to set accelerate_widget to a non-zero value
like it normally would. WindowTreeHostMus doesn't have to have a special case
for tests anymore.

BUG=717760
==========

to

==========
Install FakeContextFactory for AuraMusWmTestBase

Override AuraMusWmTestBase::SetUp() and TearDown() to use a FakeContextFactory
for its tests and restore the original ContextFactory to avoid affecting the
other tests.

Doing this allows WindowTreeHostMus to set accelerate_widget to a non-zero value
like it normally would. WindowTreeHostMus doesn't have to have a special case
for tests anymore.

BUG=717760
==========

[Alex Z., 2017-05-04 18:01:16]

https://codereview.chromium.org/2865443002/diff/1/ui/aura/test/aura_mus_test_...
File ui/aura/test/aura_mus_test_base.cc (right):

https://codereview.chromium.org/2865443002/diff/1/ui/aura/test/aura_mus_test_...
ui/aura/test/aura_mus_test_base.cc:21:
env->set_context_factory(&context_factory_);
On 2017/05/04 17:50:46, sadrul wrote:
> I think you want to do this first, before seeing up AuraTestBase?

AuraTestBase::SetUp() create an InProcessContextFactory and put it into env:
https://cs.chromium.org/chromium/src/ui/aura/test/aura_test_base.cc?l=83. If we
swap ContextFactory
before calling AuraTestBase, it gets overwritten.

https://codereview.chromium.org/2865443002/diff/1/ui/aura/test/aura_mus_test_...
ui/aura/test/aura_mus_test_base.cc:35: set_window_manager_delegate(nullptr);
On 2017/05/04 17:50:46, sadrul wrote:
> I think we should do this here too.

All aura_unittests passed without changing AuraMusClientTestBase. Do you still
want to do it here?

[Alex Z., 2017-05-05 13:33:30]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 13:33:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alex Z., 2017-05-05 13:34:35]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[Alex Z., 2017-05-05 13:34:44]

https://codereview.chromium.org/2865443002/diff/1/ui/aura/test/aura_mus_test_...
File ui/aura/test/aura_mus_test_base.cc (right):

https://codereview.chromium.org/2865443002/diff/1/ui/aura/test/aura_mus_test_...
ui/aura/test/aura_mus_test_base.cc:21:
env->set_context_factory(&context_factory_);
On 2017/05/04 17:50:46, sadrul wrote:
> I think you want to do this first, before seeing up AuraTestBase?

I added a comment explaining this here.

https://codereview.chromium.org/2865443002/diff/1/ui/aura/test/aura_mus_test_...
ui/aura/test/aura_mus_test_base.cc:35: set_window_manager_delegate(nullptr);
On 2017/05/04 17:50:46, sadrul wrote:
> I think we should do this here too.

Done.

[commit-bot: I haz the power, 2017-05-05 13:34:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 14:39:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 14:39:18]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-05-05 17:56:36]

lgtm

[Alex Z., 2017-05-05 18:50:49]

The CQ bit was checked by staraz@chromium.org

[commit-bot: I haz the power, 2017-05-05 18:51:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 18:56:45]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494010249093220,
"parent_rev": "a2604fe1f198f9a109fe26b4b9b082a7154fd3ea", "commit_rev":
"89b9688d75599341703719d88b5f09841ac4d5de"}

[commit-bot: I haz the power, 2017-05-05 18:56:57]

Description was changed from

==========
Install FakeContextFactory for AuraMusWmTestBase

Override AuraMusWmTestBase::SetUp() and TearDown() to use a FakeContextFactory
for its tests and restore the original ContextFactory to avoid affecting the
other tests.

Doing this allows WindowTreeHostMus to set accelerate_widget to a non-zero value
like it normally would. WindowTreeHostMus doesn't have to have a special case
for tests anymore.

BUG=717760
==========

to

==========
Install FakeContextFactory for AuraMusWmTestBase

Override AuraMusWmTestBase::SetUp() and TearDown() to use a FakeContextFactory
for its tests and restore the original ContextFactory to avoid affecting the
other tests.

Doing this allows WindowTreeHostMus to set accelerate_widget to a non-zero value
like it normally would. WindowTreeHostMus doesn't have to have a special case
for tests anymore.

BUG=717760

Review-Url: https://codereview.chromium.org/2865443002
Cr-Commit-Position: refs/heads/master@{#469741}
Committed:
https://chromium.googlesource.com/chromium/src/+/89b9688d75599341703719d88b5f...
==========

[commit-bot: I haz the power, 2017-05-05 18:56:58]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/89b9688d75599341703719d88b5f...