Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2865403006: webkitpy: Memoize chromium_base() and depot_tools_base(). (Closed)

Created:
3 years, 7 months ago by tkent
Modified:
3 years, 7 months ago
Reviewers:
qyearsley
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

webkitpy: Memoize chromium_base() and depot_tools_base(). It makes the code simpler. BUG=710535 Review-Url: https://codereview.chromium.org/2865403006 Cr-Commit-Position: refs/heads/master@{#471108} Committed: https://chromium.googlesource.com/chromium/src/+/031529c704a5b30efa31a7d7dfc039c6e666bad8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py View 3 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tkent
qyearsley@, would you review this please?
3 years, 7 months ago (2017-05-11 14:58:22 UTC) #6
qyearsley
lgtm
3 years, 7 months ago (2017-05-11 16:38:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865403006/1
3 years, 7 months ago (2017-05-11 22:47:49 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 23:06:49 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/031529c704a5b30efa31a7d7dfc0...

Powered by Google App Engine
This is Rietveld 408576698