Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2865323002: Relax the character limits before resorting to eTLD+1 (Closed)

Created:
3 years, 7 months ago by Miguel Garcia
Modified:
3 years, 7 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Relax the character limits before resorting to eTLD+1 BUG=717725 Review-Url: https://codereview.chromium.org/2865323002 Cr-Commit-Position: refs/heads/master@{#470527} Committed: https://chromium.googlesource.com/chromium/src/+/7bf282aee6c77b7142d25900d5fd42c822a6d24d

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M chrome/browser/notifications/notification_platform_bridge_mac.mm View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Miguel Garcia
3 years, 7 months ago (2017-05-09 15:43:00 UTC) #2
Peter Beverloo
lgtm
3 years, 7 months ago (2017-05-09 15:58:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865323002/1
3 years, 7 months ago (2017-05-09 15:59:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/448865)
3 years, 7 months ago (2017-05-09 16:59:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865323002/20001
3 years, 7 months ago (2017-05-10 09:24:24 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 11:17:42 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7bf282aee6c77b7142d25900d5fd...

Powered by Google App Engine
This is Rietveld 408576698