Upstream service worker tests to WPT

Upstream service worker tests to WPT

**install-event-type-worker**

This test is nearly identical to the version available in the Web
Platform Tests project. Update the upstream version with the only
meaningful difference between the tests: an additional assertion for the
event object provided to the service worker's `oninstall` event handler.
Extend assertions with description strings to aid debugging in case of
test failure.

**interfaces**

Extend the upstream version with the additional assertions found in the
Chromium-specific version. Remove the Chromium-specific version.
Re-locate the associated "resource" file as it is reference by
unrelated tests.

**invalid-blobtype**

Remove the Chromium-specific version because it is equivalent to the
upstream version. Simplify script resource URLs in the upstream version.

**invalid-header**

Remove the Chromium-specific version because it is equivalent to the
upstream version. Simplify script resource URLs in the upstream version.

**multiple-register**

Remove the Chromium-specific version because it is equivalent to the
upstream version. Correct a typo in an assertion message in the upstream
version.

BUG=688116, 724212
R=mek@chromium.org

Review-Url: https://codereview.chromium.org/2865313003
Cr-Commit-Position: refs/heads/master@{#472916}
Committed: https://chromium.googlesource.com/chromium/src/+/dca85dac110e00bb8a22e1b9d94fb44d44b2d518

[mike3, 2017-05-09 18:48:54]

Hi Mek,

Relatively light migration this time around. I'm proposal removal of all related
Chromium tests. Here's a comparison of the WPT and Chromium versions:

https://gist.github.com/jugglinmike/6e8a5033d4d676716f8ce26b70c987f0

[Marijn Kruisselbrink, 2017-05-16 18:35:16]

lgtm

[mike3, 2017-05-16 22:37:42]

The CQ bit was checked by mike@mikepennisi.com

[commit-bot: I haz the power, 2017-05-16 22:39:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 22:49:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 22:49:40]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mike3, 2017-05-17 19:23:10]

On 2017/05/16 22:49:40, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
>   android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
>   android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
>   android_cronet on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
>   cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
>   mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
>   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

The previous patch failed due to a merge conflict in `interface.https.html`,
introduced via the following commit to WPT:

https://github.com/w3c/web-platform-tests/commit/809ef9b49133662a83d018c1a292...

I've submitted a new patch that resolves the conflict. Now triggering a new
build.

[mike3, 2017-05-17 19:23:16]

The CQ bit was checked by mike@mikepennisi.com

[mike3, 2017-05-17 19:23:16]

The patchset sent to the CQ was uploaded after l-g-t-m from mek@chromium.org
Link to the patchset: https://codereview.chromium.org/2865313003/#ps20001
(title: "Rebase and resolve conflicts with latest WPT versions")

[commit-bot: I haz the power, 2017-05-17 19:24:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 20:21:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 20:21:04]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mike3, 2017-05-17 21:23:34]

On 2017/05/17 20:21:04, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

All reported failures came from test files not modified by this patch. I'm going
to trigger another build.

[mike3, 2017-05-17 21:23:39]

The CQ bit was checked by mike@mikepennisi.com

[commit-bot: I haz the power, 2017-05-17 21:25:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 23:06:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 23:06:02]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mike3, 2017-05-17 23:10:23]

On 2017/05/17 23:06:02, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

This was once again blocked by seemingly-unrelated tests. Matt: am I
misinterpreting the logs? Should I try a third time?

[Marijn Kruisselbrink, 2017-05-17 23:17:56]

On 2017/05/17 at 23:10:23, mike wrote:
> On 2017/05/17 23:06:02, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
> >
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
> 
> This was once again blocked by seemingly-unrelated tests. Matt: am I
misinterpreting the logs? Should I try a third time?

These seemingly unrelated tests try to include the (now deleted)
/serviceworker/resources/interfaces.js file... So the failures are real. Maybe
move the file into http/tests/credentialmanager/resources, as that seems to be
the only place left that uses the file?

[mike3, 2017-05-17 23:28:59]

On 2017/05/17 23:17:56, Marijn Kruisselbrink wrote:
> On 2017/05/17 at 23:10:23, mike wrote:
> > On 2017/05/17 23:06:02, commit-bot: I haz the power wrote:
> > > Try jobs failed on following builders:
> > >   win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
> > >
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
> > 
> > This was once again blocked by seemingly-unrelated tests. Matt: am I
> misinterpreting the logs? Should I try a third time?
> 
> These seemingly unrelated tests try to include the (now deleted)
> /serviceworker/resources/interfaces.js file... So the failures are real. Maybe
> move the file into http/tests/credentialmanager/resources, as that seems to be
> the only place left that uses the file?

Boy, is my face red. I should have known it was a user error. I'll follow up
with that fix tomorrow--thanks, Mek!

[jsbell, 2017-05-17 23:31:41]

On 2017/05/17 23:17:56, Marijn Kruisselbrink wrote:
> These seemingly unrelated tests try to include the (now deleted)
> /serviceworker/resources/interfaces.js file... So the failures are real. Maybe
> move the file into http/tests/credentialmanager/resources, as that seems to be
> the only place left that uses the file?

... and file a bug to convert 4 tests to use idlharness

(It looks pretty straightforward)

[mike3, 2017-05-18 18:39:03]

Description was changed from

==========
Upstream service worker tests to WPT

**install-event-type-worker**

This test is nearly identical to the version available in the Web
Platform Tests project. Update the upstream version with the only
meaningful difference between the tests: an additional assertion for the
event object provided to the service worker's `oninstall` event handler.
Extend assertions with description strings to aid debugging in case of
test failure.

**interfaces**

Extend the upstream version with the additional assertions found in the
Chromium-specific version. Remove the Chromium-specific version.

**invalid-blobtype**

Remove the Chromium-specific version because it is equivalent to the
upstream version. Simplify script resource URLs in the upstream version.

**invalid-header**

Remove the Chromium-specific version because it is equivalent to the
upstream version. Simplify script resource URLs in the upstream version.

**multiple-register**

Remove the Chromium-specific version because it is equivalent to the
upstream version. Correct a typo in an assertion message in the upstream
version.

BUG=688116
R=mek@chromium.org
==========

to

==========
Upstream service worker tests to WPT

**install-event-type-worker**

This test is nearly identical to the version available in the Web
Platform Tests project. Update the upstream version with the only
meaningful difference between the tests: an additional assertion for the
event object provided to the service worker's `oninstall` event handler.
Extend assertions with description strings to aid debugging in case of
test failure.

**interfaces**

Extend the upstream version with the additional assertions found in the
Chromium-specific version. Remove the Chromium-specific version.
Re-locate the associated "resource" file as it is reference by
unrelated tests.

**invalid-blobtype**

Remove the Chromium-specific version because it is equivalent to the
upstream version. Simplify script resource URLs in the upstream version.

**invalid-header**

Remove the Chromium-specific version because it is equivalent to the
upstream version. Simplify script resource URLs in the upstream version.

**multiple-register**

Remove the Chromium-specific version because it is equivalent to the
upstream version. Correct a typo in an assertion message in the upstream
version.

BUG=688116, 724212
R=mek@chromium.org
==========

[mike3, 2017-05-18 18:39:36]

On 2017/05/17 23:31:41, jsbell wrote:
> On 2017/05/17 23:17:56, Marijn Kruisselbrink wrote:
> > These seemingly unrelated tests try to include the (now deleted)
> > /serviceworker/resources/interfaces.js file... So the failures are real.
Maybe
> > move the file into http/tests/credentialmanager/resources, as that seems to
be
> > the only place left that uses the file?
> 
> ... and file a bug to convert 4 tests to use idlharness
> 
> (It looks pretty straightforward)

Done and done https://bugs.chromium.org/p/chromium/issues/detail?id=724212

[mike3, 2017-05-18 18:41:43]

The CQ bit was checked by mike@mikepennisi.com

[mike3, 2017-05-18 18:41:44]

The patchset sent to the CQ was uploaded after l-g-t-m from mek@chromium.org
Link to the patchset: https://codereview.chromium.org/2865313003/#ps40001
(title: "Re-introduce resource script")

[commit-bot: I haz the power, 2017-05-18 18:43:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 20:36:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495132903489960,
"parent_rev": "ba5159d871bb21b4b151262dd9234d0261b81331", "commit_rev":
"dca85dac110e00bb8a22e1b9d94fb44d44b2d518"}

[commit-bot: I haz the power, 2017-05-18 20:36:44]

Description was changed from

==========
Upstream service worker tests to WPT

**install-event-type-worker**

This test is nearly identical to the version available in the Web
Platform Tests project. Update the upstream version with the only
meaningful difference between the tests: an additional assertion for the
event object provided to the service worker's `oninstall` event handler.
Extend assertions with description strings to aid debugging in case of
test failure.

**interfaces**

Extend the upstream version with the additional assertions found in the
Chromium-specific version. Remove the Chromium-specific version.
Re-locate the associated "resource" file as it is reference by
unrelated tests.

**invalid-blobtype**

Remove the Chromium-specific version because it is equivalent to the
upstream version. Simplify script resource URLs in the upstream version.

**invalid-header**

Remove the Chromium-specific version because it is equivalent to the
upstream version. Simplify script resource URLs in the upstream version.

**multiple-register**

Remove the Chromium-specific version because it is equivalent to the
upstream version. Correct a typo in an assertion message in the upstream
version.

BUG=688116, 724212
R=mek@chromium.org
==========

to

==========
Upstream service worker tests to WPT

**install-event-type-worker**

This test is nearly identical to the version available in the Web
Platform Tests project. Update the upstream version with the only
meaningful difference between the tests: an additional assertion for the
event object provided to the service worker's `oninstall` event handler.
Extend assertions with description strings to aid debugging in case of
test failure.

**interfaces**

Extend the upstream version with the additional assertions found in the
Chromium-specific version. Remove the Chromium-specific version.
Re-locate the associated "resource" file as it is reference by
unrelated tests.

**invalid-blobtype**

Remove the Chromium-specific version because it is equivalent to the
upstream version. Simplify script resource URLs in the upstream version.

**invalid-header**

Remove the Chromium-specific version because it is equivalent to the
upstream version. Simplify script resource URLs in the upstream version.

**multiple-register**

Remove the Chromium-specific version because it is equivalent to the
upstream version. Correct a typo in an assertion message in the upstream
version.

BUG=688116, 724212
R=mek@chromium.org

Review-Url: https://codereview.chromium.org/2865313003
Cr-Commit-Position: refs/heads/master@{#472916}
Committed:
https://chromium.googlesource.com/chromium/src/+/dca85dac110e00bb8a22e1b9d94f...
==========

[commit-bot: I haz the power, 2017-05-18 20:36:45]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/dca85dac110e00bb8a22e1b9d94f...