Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2865313002: [regexp] Don't adapt arguments for @@replace and @@split (Closed)

Created:
3 years, 7 months ago by jgruber
Modified:
3 years, 7 months ago
Reviewers:
gsathya
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Don't adapt arguments for @@replace and @@split Mechanical change to remove argument adaption from RegExp.p.split, RegExp.p.replace when the actual arguments counts does not match the formal parameter count (should be a tad faster this way). BUG=v8:6369 Review-Url: https://codereview.chromium.org/2865313002 Cr-Commit-Position: refs/heads/master@{#45219} Committed: https://chromium.googlesource.com/v8/v8/+/9fbfd6ead6f7406ca4912610c501146622fa98ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -20 lines) Patch
M src/bootstrapper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-definitions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-regexp-gen.cc View 4 chunks +34 lines, -16 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
jgruber
Hey, PTAL!
3 years, 7 months ago (2017-05-09 14:52:51 UTC) #4
gsathya
On 2017/05/09 14:52:51, jgruber wrote: > Hey, PTAL! Nice! Can you please update the description ...
3 years, 7 months ago (2017-05-09 15:05:54 UTC) #5
jgruber
On 2017/05/09 15:05:54, gsathya wrote: > On 2017/05/09 14:52:51, jgruber wrote: > > Hey, PTAL! ...
3 years, 7 months ago (2017-05-10 06:50:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865313002/1
3 years, 7 months ago (2017-05-10 06:50:24 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 06:52:06 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/9fbfd6ead6f7406ca4912610c501146622f...

Powered by Google App Engine
This is Rietveld 408576698