Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2865253004: [Merge to M59] Fix DPI scaling on Linux with GTK3 (Closed)

Created:
3 years, 7 months ago by Tom Anderson
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Merge to M59] Fix DPI scaling on Linux with GTK3 > The device scale was determined by querying the value of the > "gtk-xft-dpi" property from GtkSettings. In GTK2, this always returned > the value of the "Xft/DPI" XSettings property. However, in GTK3, this > returns the value of "Gdk/UnscaledDPI" if it is set, resulting in the > wrong device scale being calculated on high DPI screens. > > Instead, we now query the "gdk-window-scaling-factor" setting from > GdkScreen, which is derived from the value of the > "Gdk/WindowScalingFactor" XSettings property. If this property is not > set then we fall back to the previous code path, as environments that > don't provide Gdk/WindowScalingFactor also won't provide > Gdk/UnscaledDPI. > > BUG=716135 > TBR=erg@chromium.org > > patch from issue 2852593002 at patchset 20001 (http://crrev.com/2852593002#ps20001) > > Review-Url: https://codereview.chromium.org/2869763004 > Cr-Commit-Position: refs/heads/master@{#470142} BUG=716135 TBR=erg@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2865253004 Cr-Commit-Position: refs/branch-heads/3071@{#481} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/2c2751e4ab72020be05c7089047cdc4be6cd3923

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M chrome/browser/ui/libgtkui/gtk_ui.cc View 1 chunk +21 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865253004/1
3 years, 7 months ago (2017-05-09 17:52:22 UTC) #2
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 17:54:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2c2751e4ab72020be05c7089047c...

Powered by Google App Engine
This is Rietveld 408576698