memory-infra: Rename Enable/Disable in MemoryDumpManager.

memory-infra: Rename Enable/Disable in MemoryDumpManager.

Enable/Disable are no longer required to use MemoryDumpManager so rename them to SetupForTracing/TeardownForTracing to more accurately match their use.

BUG=703184
Review-Url: https://codereview.chromium.org/2865243003
Cr-Commit-Position: refs/heads/master@{#470541}
Committed: https://chromium.googlesource.com/chromium/src/+/00e2bf72c7611ea4c166bb53bdcc7a7ae3e35bb6

[hjd, 2017-05-09 11:05:10]

Description was changed from

==========
memory-infra: Rename Enable/Disable in MemoryDumpManager.


memory-infra: Remove is_enabled_ from MDM

This is one step the eventual refactor to remove Enable/Disable.

BUG=705564
==========

to

==========
memory-infra: Rename Enable/Disable in MemoryDumpManager.

Enable/Disable are no longer required to use MemoryDumpManager so rename them to
SetupForTracing/TeardownForTracing to more accurately match their use.

BUG=703184
==========

[hjd, 2017-05-09 11:05:10]

hjd@chromium.org changed reviewers:
+ primiano@chromium.org, ssid@chromium.org

[hjd, 2017-05-09 11:06:15]

On 2017/05/09 11:05:10, hjd wrote:
> mailto:hjd@chromium.org changed reviewers:
> + mailto:primiano@chromium.org, mailto:ssid@chromium.org

ptal, thanks!

[Primiano Tucci (use gerrit), 2017-05-09 12:34:11]

lgtm

https://codereview.chromium.org/2865243003/diff/40001/base/trace_event/memory...
File base/trace_event/memory_dump_manager.h (right):

https://codereview.chromium.org/2865243003/diff/40001/base/trace_event/memory...
base/trace_event/memory_dump_manager.h:135: // Tear-down tracing related state.
maybe just clarify in the comment that the all the other, non-tracing related 
operations (e.g. SUMMARY-ONLY) still work after this.

[ssid, 2017-05-09 18:15:07]

lgtm

[hjd, 2017-05-10 11:13:21]

The CQ bit was checked by hjd@chromium.org

[hjd, 2017-05-10 11:13:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org, ssid@chromium.org
Link to the patchset: https://codereview.chromium.org/2865243003/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-10 11:13:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 12:30:04]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494414801507960,
"parent_rev": "302fb6818a801cdcaa88da9cda90bfc22077a548", "commit_rev":
"00e2bf72c7611ea4c166bb53bdcc7a7ae3e35bb6"}

[commit-bot: I haz the power, 2017-05-10 12:30:18]

Description was changed from

==========
memory-infra: Rename Enable/Disable in MemoryDumpManager.

Enable/Disable are no longer required to use MemoryDumpManager so rename them to
SetupForTracing/TeardownForTracing to more accurately match their use.

BUG=703184
==========

to

==========
memory-infra: Rename Enable/Disable in MemoryDumpManager.

Enable/Disable are no longer required to use MemoryDumpManager so rename them to
SetupForTracing/TeardownForTracing to more accurately match their use.

BUG=703184

Review-Url: https://codereview.chromium.org/2865243003
Cr-Commit-Position: refs/heads/master@{#470541}
Committed:
https://chromium.googlesource.com/chromium/src/+/00e2bf72c7611ea4c166bb53bdcc...
==========

[commit-bot: I haz the power, 2017-05-10 12:30:20]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/00e2bf72c7611ea4c166bb53bdcc...