Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 2865243002: Implement chrome://blob-internals with network service. (Closed)

Created:
3 years, 7 months ago by jam
Modified:
3 years, 7 months ago
Reviewers:
dmurph
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement chrome://blob-internals with network service. BUG=717714 Review-Url: https://codereview.chromium.org/2865243002 Cr-Commit-Position: refs/heads/master@{#470423} Committed: https://chromium.googlesource.com/chromium/src/+/d654ee5a83218d46fb8198d1787100f515014932

Patch Set 1 #

Patch Set 2 : self nit #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -30 lines) Patch
M content/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A content/browser/blob_storage/blob_internals_url_loader.h View 1 chunk +19 lines, -0 lines 0 comments Download
A content/browser/blob_storage/blob_internals_url_loader.cc View 1 1 chunk +63 lines, -0 lines 1 comment Download
M content/browser/webui/web_ui_url_loader_factory.cc View 5 chunks +18 lines, -6 lines 0 comments Download
M storage/browser/blob/view_blob_internals_job.h View 1 chunk +2 lines, -1 line 0 comments Download
M storage/browser/blob/view_blob_internals_job.cc View 1 chunk +27 lines, -23 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
jam
3 years, 7 months ago (2017-05-09 14:22:27 UTC) #9
dmurph
lgtm https://codereview.chromium.org/2865243002/diff/20001/content/browser/blob_storage/blob_internals_url_loader.cc File content/browser/blob_storage/blob_internals_url_loader.cc (right): https://codereview.chromium.org/2865243002/diff/20001/content/browser/blob_storage/blob_internals_url_loader.cc#newcode13 content/browser/blob_storage/blob_internals_url_loader.cc:13: void StartBlobInternalsURLLoader( I trust this is correct - ...
3 years, 7 months ago (2017-05-09 20:45:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865243002/20001
3 years, 7 months ago (2017-05-09 20:52:30 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 22:01:09 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d654ee5a83218d46fb8198d17871...

Powered by Google App Engine
This is Rietveld 408576698