Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2865233002: Generate INVALID_OPERATION when depth/stencil textures are specified using targets other than TEXTU… (Closed)

Created:
3 years, 7 months ago by Zhenyao Mo
Modified:
3 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, jam, darin-cc_chromium.org, Kai Ninomiya, Ken Russell (switch to Gerrit)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate INVALID_OPERATION when depth/stencil textures are specified using targets other than TEXTURE_2D in ES2/WebGL1. Also, Roll in related WebGL conformance test to have test coverage: https://chromium.googlesource.com/external/khronosgroup/webgl.git/+/73b300f24942adf7013de30ccdc6a2cc88105e72 BUG=718846 TEST=webgl_conformance R=piman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2865233002 Cr-Commit-Position: refs/heads/master@{#470386} Committed: https://chromium.googlesource.com/chromium/src/+/d5523a250fa3faed2930cabcc13ac0746c1cfb2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_revision.txt View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Zhenyao Mo
piman: minor CL, please take a look.
3 years, 7 months ago (2017-05-08 23:54:42 UTC) #3
piman
LGTM. GL_OES_depth_texture explicitly calls it out, and there is a separate GL_OES_depth_texture_cube_map extension that allows ...
3 years, 7 months ago (2017-05-09 00:10:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865233002/1
3 years, 7 months ago (2017-05-09 17:01:07 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 18:15:35 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d5523a250fa3faed2930cabcc13a...

Powered by Google App Engine
This is Rietveld 408576698