Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2865213002:
Remove a small range of Tibetan characters from the allowed IDN set on Mac. (Closed)
|
Created:
3 years, 7 months ago by Robert Sesek Modified:
3 years, 7 months ago CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove a small range of Tibetan characters from the allowed IDN set on Mac.
These characters do not display in the default macOS system font, despite the
font reporting that the glyphs are present.
BUG=714196
Review-Url: https://codereview.chromium.org/2865213002
Cr-Commit-Position: refs/heads/master@{#470407}
Committed: https://chromium.googlesource.com/chromium/src/+/bccbe7c22a38f68da0c4d0bb9258060f2554e318
Patch Set 1 #
Messages
Total messages: 22 (11 generated)
The CQ bit was checked by rsesek@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
rsesek@chromium.org changed reviewers: + jshin@chromium.org
LGTM with bots happy (not likely to be caused by this CL).
The CQ bit was checked by jshin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
rsesek@chromium.org changed reviewers: + pkasting@chromium.org
+pkasting for OWNERS
LGTM. I'm kinda sad that the same URL will now render as Unicode on Chrome/Win and punycode on Chrome/Mac, and I'm almost inclined to just ban these on all platforms for consistency. But I don't know for sure.
On 2017/05/09 17:49:05, Peter Kasting wrote: > LGTM. > > I'm kinda sad that the same URL will now render as Unicode on Chrome/Win and > punycode on Chrome/Mac, and I'm almost inclined to just ban these on all > platforms for consistency. But I don't know for sure. I can definitely go that route, but I figured I'd scope it as narrowly as possible. From my research, I'd say these characters will almost never appear in any domain. Do you have a preference?
On 2017/05/09 18:02:47, Robert Sesek wrote: > On 2017/05/09 17:49:05, Peter Kasting wrote: > > LGTM. > > > > I'm kinda sad that the same URL will now render as Unicode on Chrome/Win and > > punycode on Chrome/Mac, and I'm almost inclined to just ban these on all > > platforms for consistency. But I don't know for sure. > > I can definitely go that route, but I figured I'd scope it as narrowly as > possible. From my research, I'd say these characters will almost never appear in > any domain. Do you have a preference? Not really? I figure if anyone would have a preference it'd be people like Jungshik or the security folks.
On 2017/05/09 18:05:12, Peter Kasting wrote: > On 2017/05/09 18:02:47, Robert Sesek wrote: > > On 2017/05/09 17:49:05, Peter Kasting wrote: > > > LGTM. > > > > > > I'm kinda sad that the same URL will now render as Unicode on Chrome/Win and > > > punycode on Chrome/Mac, and I'm almost inclined to just ban these on all > > > platforms for consistency. But I don't know for sure. > > > > I can definitely go that route, but I figured I'd scope it as narrowly as > > possible. From my research, I'd say these characters will almost never appear > in > > any domain. Do you have a preference? > > Not really? I figure if anyone would have a preference it'd be people like > Jungshik or the security folks. OK. I don't have a preference either, so I'm going to land this to fix the bug. It's trivial to make apply this to all platforms if we choose.
The CQ bit was checked by rsesek@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494355661634580, "parent_rev":
"5521f3cd48f8925be1bfbf74c8d7c3881ec7219b", "commit_rev":
"bccbe7c22a38f68da0c4d0bb9258060f2554e318"}
Message was sent while issue was closed.
Description was changed from ========== Remove a small range of Tibetan characters from the allowed IDN set on Mac. These characters do not display in the default macOS system font, despite the font reporting that the glyphs are present. BUG=714196 ========== to ========== Remove a small range of Tibetan characters from the allowed IDN set on Mac. These characters do not display in the default macOS system font, despite the font reporting that the glyphs are present. BUG=714196 Review-Url: https://codereview.chromium.org/2865213002 Cr-Commit-Position: refs/heads/master@{#470407} Committed: https://chromium.googlesource.com/chromium/src/+/bccbe7c22a38f68da0c4d0bb9258... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/bccbe7c22a38f68da0c4d0bb9258... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
