ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn - Issue 2865183003: Use the same design for all suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn

Issue 2865183003: Use the same design for all suggestions (Closed)

Patch Set: Address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/content_suggestions/BUILD.gn ('k') | ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn

diff --git a/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn b/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn

index 49fc3a1b11afcc11d9fb657c30e10081ade8024e..a42fb2aef9c042dc06269032a34540d3dda7bfdb 100644

--- a/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn

+++ b/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn

@@ -4,14 +4,12 @@

source_set("cells") {

sources = [

- "content_suggestions_article_item.h",

- "content_suggestions_article_item.mm",

"content_suggestions_footer_item.h",

"content_suggestions_footer_item.mm",

+ "content_suggestions_item.h",

+ "content_suggestions_item.mm",

"content_suggestions_most_visited_item.h",

"content_suggestions_most_visited_item.mm",

- "content_suggestions_reading_list_item.h",

- "content_suggestions_reading_list_item.mm",

"content_suggestions_text_item.h",

"content_suggestions_text_item.mm",

]

@@ -22,7 +20,6 @@ source_set("cells") {

"//ios/chrome/browser/ui/colors",

"//ios/chrome/browser/ui/content_suggestions/identifier",

"//ios/chrome/browser/ui/favicon:favicon_ui",

- "//ios/chrome/browser/ui/reading_list",

"//ios/chrome/browser/ui/util",

"//ui/base",

"//url",

@@ -33,8 +30,8 @@ source_set("cells") {

source_set("unit_tests") {

testonly = true

sources = [

- "content_suggestions_article_item_unittest.mm",

"content_suggestions_footer_item_unittest.mm",

+ "content_suggestions_item_unittest.mm",

"content_suggestions_most_visited_item_unittest.mm",

]

deps = [