ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn - Issue 2865183003: Use the same design for all suggestions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn

Issue 2865183003: Use the same design for all suggestions (Closed)

Patch Set: Address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ios/chrome/browser/ui/content_suggestions/BUILD.gn ('k') | ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2017 The Chromium Authors. All rights reserved.	1 # Copyright 2017 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 source_set("cells") {	5 source_set("cells") {

6 sources = [	6 sources = [

7 "content_suggestions_article_item.h",

8 "content_suggestions_article_item.mm",

9 "content_suggestions_footer_item.h",	7 "content_suggestions_footer_item.h",

10 "content_suggestions_footer_item.mm",	8 "content_suggestions_footer_item.mm",

	9 "content_suggestions_item.h",

	10 "content_suggestions_item.mm",

11 "content_suggestions_most_visited_item.h",	11 "content_suggestions_most_visited_item.h",

12 "content_suggestions_most_visited_item.mm",	12 "content_suggestions_most_visited_item.mm",

13 "content_suggestions_reading_list_item.h",

14 "content_suggestions_reading_list_item.mm",

15 "content_suggestions_text_item.h",	13 "content_suggestions_text_item.h",

16 "content_suggestions_text_item.mm",	14 "content_suggestions_text_item.mm",

17 ]	15 ]

18 deps = [	16 deps = [

19 "//base",	17 "//base",

20 "//ios/chrome/browser/ui",	18 "//ios/chrome/browser/ui",

21 "//ios/chrome/browser/ui/collection_view",	19 "//ios/chrome/browser/ui/collection_view",

22 "//ios/chrome/browser/ui/colors",	20 "//ios/chrome/browser/ui/colors",

23 "//ios/chrome/browser/ui/content_suggestions/identifier",	21 "//ios/chrome/browser/ui/content_suggestions/identifier",

24 "//ios/chrome/browser/ui/favicon:favicon_ui",	22 "//ios/chrome/browser/ui/favicon:favicon_ui",

25 "//ios/chrome/browser/ui/reading_list",

26 "//ios/chrome/browser/ui/util",	23 "//ios/chrome/browser/ui/util",

27 "//ui/base",	24 "//ui/base",

28 "//url",	25 "//url",

29 ]	26 ]

30 configs += [ "//build/config/compiler:enable_arc" ]	27 configs += [ "//build/config/compiler:enable_arc" ]

31 }	28 }

32	29

33 source_set("unit_tests") {	30 source_set("unit_tests") {

34 testonly = true	31 testonly = true

35 sources = [	32 sources = [

36 "content_suggestions_article_item_unittest.mm",

37 "content_suggestions_footer_item_unittest.mm",	33 "content_suggestions_footer_item_unittest.mm",

	34 "content_suggestions_item_unittest.mm",

38 "content_suggestions_most_visited_item_unittest.mm",	35 "content_suggestions_most_visited_item_unittest.mm",

39 ]	36 ]

40 deps = [	37 deps = [

41 ":cells",	38 ":cells",

42 "//base",	39 "//base",

43 "//ios/chrome/browser/ui",	40 "//ios/chrome/browser/ui",

44 "//ios/chrome/browser/ui/collection_view",	41 "//ios/chrome/browser/ui/collection_view",

45 "//ios/chrome/browser/ui/favicon:favicon_ui",	42 "//ios/chrome/browser/ui/favicon:favicon_ui",

46 "//testing/gtest",	43 "//testing/gtest",

47 "//third_party/ocmock",	44 "//third_party/ocmock",

48 "//url",	45 "//url",

49 ]	46 ]

50 configs += [ "//build/config/compiler:enable_arc" ]	47 configs += [ "//build/config/compiler:enable_arc" ]

51 }	48 }

OLD	NEW