Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2865133005: Create accessor for owner's manager to simplify code a bit (Closed)

Created:
3 years, 7 months ago by dougt
Modified:
3 years, 7 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Create accessor for owner's manager to simplify code a bit BUG=703369 Review-Url: https://codereview.chromium.org/2865133005 Cr-Commit-Position: refs/heads/master@{#470663} Committed: https://chromium.googlesource.com/chromium/src/+/5a1c7507804d3955f71fa3f2d55461dfcf556245

Patch Set 1 #

Total comments: 2

Patch Set 2 : address dmazzoni's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -32 lines) Patch
M content/browser/accessibility/browser_accessibility_com_win.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_com_win.cc View 1 23 chunks +37 lines, -32 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (12 generated)
dougt
3 years, 7 months ago (2017-05-09 18:52:24 UTC) #2
dmazzoni
https://codereview.chromium.org/2865133005/diff/1/content/browser/accessibility/browser_accessibility_com_win.cc File content/browser/accessibility/browser_accessibility_com_win.cc (right): https://codereview.chromium.org/2865133005/diff/1/content/browser/accessibility/browser_accessibility_com_win.cc#newcode4092 content/browser/accessibility/browser_accessibility_com_win.cc:4092: if (!owner) Doesn't every single method call GetOwner at ...
3 years, 7 months ago (2017-05-10 06:10:04 UTC) #7
dougt
dmazzoni, thank you for the quick turn around! ptal.
3 years, 7 months ago (2017-05-10 06:33:05 UTC) #8
dmazzoni
lgtm
3 years, 7 months ago (2017-05-10 16:22:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865133005/20001
3 years, 7 months ago (2017-05-10 18:59:03 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 19:08:39 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5a1c7507804d3955f71fa3f2d554...

Powered by Google App Engine
This is Rietveld 408576698