Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2865113007: Remove ScopedVector from media/base/ (Closed)

Created:
3 years, 7 months ago by Chandan
Modified:
3 years, 7 months ago
Reviewers:
chcunningham, xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector from media/base/ base::ScopedVector is deprecated. This CL replaces ScopedVector with std::vector<std::unique_ptr> in media/base/ except in [1] and [2]. Removing ScopedVector in [1] and [2] involves changes outside media/base/. I will take up these in seperate CLs. [1] media/base/content_decryption_module.h [2] media/base/decoder_factory.h BUG=554289 Review-Url: https://codereview.chromium.org/2865113007 Cr-Commit-Position: refs/heads/master@{#470872} Committed: https://chromium.googlesource.com/chromium/src/+/e6be43e51ab2b92ae4fa55745bd54c8ee09f155d

Patch Set 1 #

Total comments: 2

Patch Set 2 : added header file in text_renderer_unittest.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -31 lines) Patch
M media/base/audio_block_fifo.h View 2 chunks +1 line, -2 lines 0 comments Download
M media/base/audio_block_fifo.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M media/base/audio_converter_unittest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M media/base/audio_renderer_mixer_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/base/multi_channel_resampler.h View 2 chunks +1 line, -2 lines 0 comments Download
M media/base/multi_channel_resampler.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M media/base/text_renderer_unittest.cc View 1 8 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Chandan
PTAL. Thank you.
3 years, 7 months ago (2017-05-09 15:33:13 UTC) #8
Chandan
It seems chcunningham@ is OOO. xhwang@, PTAL. Thank you.
3 years, 7 months ago (2017-05-10 17:10:18 UTC) #10
xhwang
LGTM with nit. Thanks for working on this! https://codereview.chromium.org/2865113007/diff/1/media/base/text_renderer_unittest.cc File media/base/text_renderer_unittest.cc (right): https://codereview.chromium.org/2865113007/diff/1/media/base/text_renderer_unittest.cc#newcode14 media/base/text_renderer_unittest.cc:14: #include ...
3 years, 7 months ago (2017-05-10 17:24:48 UTC) #11
Chandan
Thanks! https://codereview.chromium.org/2865113007/diff/1/media/base/text_renderer_unittest.cc File media/base/text_renderer_unittest.cc (right): https://codereview.chromium.org/2865113007/diff/1/media/base/text_renderer_unittest.cc#newcode14 media/base/text_renderer_unittest.cc:14: #include "base/macros.h" On 2017/05/10 17:24:48, xhwang wrote: > ...
3 years, 7 months ago (2017-05-11 06:04:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865113007/20001
3 years, 7 months ago (2017-05-11 06:04:41 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 08:10:28 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e6be43e51ab2b92ae4fa55745bd5...

Powered by Google App Engine
This is Rietveld 408576698