Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2865063003: Add an end-to-end test for sign-in profile apps installation (Closed)

Created:
3 years, 7 months ago by emaxx
Modified:
3 years, 7 months ago
Reviewers:
achuithb, lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an end-to-end test for sign-in profile apps installation This adds several browser tests for the sign-in profile apps installation via the device policy. These tests cover the crucial parts of this functionality: obtaining the list of apps to be installed from the device policy, fetching the apps' update manifests, fetching apps' CRX packages, installing them and launching. The tests also check that extensions (as opposed to apps) are not allowed to be installed in the sign-in profile, and that non-whitelisted apps are accepted only on specific browser channels. Also a new test app is introduced and whitelisted for the execution in the sign-in profile. The test app is also published on WebStore (so that it can be safely maintained and used without leaking the private key). This app is planned to be used for the manual testing too. BUG=626343 TEST=new browser tests Review-Url: https://codereview.chromium.org/2865063003 Cr-Commit-Position: refs/heads/master@{#470530} Committed: https://chromium.googlesource.com/chromium/src/+/044dbd1b936309e5cc73c52280a73336364d46ec

Patch Set 1 #

Total comments: 14

Patch Set 2 : Fix nits #

Patch Set 3 : Remove dependency on http://crrev.com/2854293003 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+476 lines, -6 lines) Patch
M chrome/browser/chromeos/policy/signin_profile_apps_policy_browsertest.cc View 1 2 2 chunks +308 lines, -5 lines 0 comments Download
A chrome/test/data/extensions/signin_screen_test_app/README View 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/signin_screen_test_app/app.crx View Binary file 0 comments Download
A chrome/test/data/extensions/signin_screen_test_app/app/background.js View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/signin_screen_test_app/app/manifest.json View 1 chunk +11 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/signin_screen_test_app/update_manifest.xml View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/trivial_extension/README View 1 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/trivial_extension/extension.crx View 1 Binary file 0 comments Download
A chrome/test/data/extensions/trivial_extension/extension.pem View 1 chunk +28 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/trivial_extension/extension/background.js View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/trivial_extension/extension/manifest.json View 1 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/trivial_extension/update_manifest.xml View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/trivial_platform_app/README View 1 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/trivial_platform_app/app.crx View 1 Binary file 0 comments Download
A chrome/test/data/extensions/trivial_platform_app/app.pem View 1 chunk +28 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/trivial_platform_app/app/background.js View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/trivial_platform_app/app/manifest.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/trivial_platform_app/update_manifest.xml View 1 chunk +12 lines, -0 lines 0 comments Download
M extensions/common/api/_behavior_features.json View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 38 (26 generated)
emaxx
Achuith, PTAL.
3 years, 7 months ago (2017-05-08 16:05:12 UTC) #4
emaxx
+OWNERS lazyboy@: Please review extensions/common/api/_behavior_features.json.
3 years, 7 months ago (2017-05-08 21:24:53 UTC) #9
lazyboy
_behavior_features.json lgtm
3 years, 7 months ago (2017-05-08 23:43:20 UTC) #12
achuithb
This is excellent work! LGTM. https://codereview.chromium.org/2865063003/diff/1/chrome/browser/chromeos/policy/signin_profile_apps_policy_browsertest.cc File chrome/browser/chromeos/policy/signin_profile_apps_policy_browsertest.cc (right): https://codereview.chromium.org/2865063003/diff/1/chrome/browser/chromeos/policy/signin_profile_apps_policy_browsertest.cc#newcode70 chrome/browser/chromeos/policy/signin_profile_apps_policy_browsertest.cc:70: class ExtensionInstallErrorObserver final { ...
3 years, 7 months ago (2017-05-08 23:49:46 UTC) #13
emaxx
Thanks for the quick reviewing guys! https://codereview.chromium.org/2865063003/diff/1/chrome/browser/chromeos/policy/signin_profile_apps_policy_browsertest.cc File chrome/browser/chromeos/policy/signin_profile_apps_policy_browsertest.cc (right): https://codereview.chromium.org/2865063003/diff/1/chrome/browser/chromeos/policy/signin_profile_apps_policy_browsertest.cc#newcode70 chrome/browser/chromeos/policy/signin_profile_apps_policy_browsertest.cc:70: class ExtensionInstallErrorObserver final ...
3 years, 7 months ago (2017-05-09 15:03:35 UTC) #23
emaxx
Decided to land this CL temporarily without the tests for the Stable channel, as the ...
3 years, 7 months ago (2017-05-09 21:28:25 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865063003/40001
3 years, 7 months ago (2017-05-09 21:30:18 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/366441)
3 years, 7 months ago (2017-05-10 02:19:41 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865063003/40001
3 years, 7 months ago (2017-05-10 02:27:50 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-10 04:30:19 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865063003/40001
3 years, 7 months ago (2017-05-10 10:49:34 UTC) #35
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 11:20:24 UTC) #38
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/044dbd1b936309e5cc73c52280a7...

Powered by Google App Engine
This is Rietveld 408576698