Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2865003002: Make ModulatorImpl execution-context-agnostic (Closed)

Created:
3 years, 7 months ago by nhiroki
Modified:
3 years, 7 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ModulatorImpl execution-context-agnostic This CL enables Worklet to reuse ModulatorImpl for its script loading. This is split from https://codereview.chromium.org/2826313003/ BUG=627945 Review-Url: https://codereview.chromium.org/2865003002 Cr-Commit-Position: refs/heads/master@{#469924} Committed: https://chromium.googlesource.com/chromium/src/+/32ad6568b0726bf88a1cc0a2cd0e9eaff84d8292

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M third_party/WebKit/Source/core/dom/Modulator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ModulatorImpl.h View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ModulatorImpl.cpp View 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
nhiroki
PTAL
3 years, 7 months ago (2017-05-08 04:20:27 UTC) #4
kouhei (in TOK)
I'd remove "worklet: " from CL title. otherwise lgtm
3 years, 7 months ago (2017-05-08 04:41:35 UTC) #7
nhiroki
Thank you! On 2017/05/08 04:41:35, kouhei (on transit) wrote: > I'd remove "worklet: " from ...
3 years, 7 months ago (2017-05-08 04:45:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865003002/1
3 years, 7 months ago (2017-05-08 04:45:22 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 08:39:28 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/32ad6568b0726bf88a1cc0a2cd0e...

Powered by Google App Engine
This is Rietveld 408576698