Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2864893002: Remove disabling reference logic for blink_perf benchmarks (Closed)

Created:
3 years, 7 months ago by nednguyen
Modified:
3 years, 7 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove disabling reference logic for blink_perf benchmarks BUG=707237, 653970, 576779 TBR=charliea@chromium.org Review-Url: https://codereview.chromium.org/2864893002 Cr-Commit-Position: refs/heads/master@{#470263} Committed: https://chromium.googlesource.com/chromium/src/+/39cbe807824bdd083a40d66a9958b1fdfb5a8af8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M tools/perf/benchmarks/blink_perf.py View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
nednguyen
3 years, 7 months ago (2017-05-08 21:12:40 UTC) #2
martiniss
lgtm
3 years, 7 months ago (2017-05-08 21:26:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864893002/1
3 years, 7 months ago (2017-05-08 21:36:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/288476) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 7 months ago (2017-05-08 23:26:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864893002/1
3 years, 7 months ago (2017-05-08 23:35:33 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/421403)
3 years, 7 months ago (2017-05-09 03:23:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864893002/1
3 years, 7 months ago (2017-05-09 05:55:18 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 07:46:16 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/39cbe807824bdd083a40d66a9958...

Powered by Google App Engine
This is Rietveld 408576698