Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2864763002: Update autocomplete's sync bridge's unittest's proc usage. (Closed)

Created:
3 years, 7 months ago by skym
Modified:
3 years, 7 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update autocomplete's sync bridge's unittest's proc usage. A small refactoring that I saw an opportunity for while writing https://codereview.chromium.org/2856933005/ BUG= Review-Url: https://codereview.chromium.org/2864763002 Cr-Commit-Position: refs/heads/master@{#469974} Committed: https://chromium.googlesource.com/chromium/src/+/833ccd4730d60e98f29eda9c41dd00f01cc82cad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -38 lines) Patch
M components/autofill/core/browser/webdata/autocomplete_sync_bridge_unittest.cc View 13 chunks +28 lines, -38 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (6 generated)
skym
PTAL
3 years, 7 months ago (2017-05-05 21:54:02 UTC) #4
Mathieu
lgtm
3 years, 7 months ago (2017-05-08 13:03:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864763002/1
3 years, 7 months ago (2017-05-08 13:03:45 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 13:59:34 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/833ccd4730d60e98f29eda9c41dd...

Powered by Google App Engine
This is Rietveld 408576698