Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2864753004: M59: Clear the PrintContext in WebLocalFrameImpl::Close(). (Closed)

Created:
3 years, 7 months ago by Lei Zhang
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

M59: Clear the PrintContext in WebLocalFrameImpl::Close(). Also explicitly call PrintContext::EndPrintMode(), rather than calling it in the destructor. Add a ScopedPrintMode helper class to do that conveniently. BUG=716474 Review-Url: https://codereview.chromium.org/2848823005 Cr-Commit-Position: refs/heads/master@{#468882} (cherry picked from commit 85b7d7b31f25da2481ab2fa569c7b37a42abdeb6) Review-Url: https://codereview.chromium.org/2864753004 . Cr-Commit-Position: refs/branch-heads/3071@{#429} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/85199fb739f0c8b8e491cd6f1ac538efb4134ad0

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -52 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp View 1 1 chunk +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/PrintContext.h View 5 chunks +19 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/PrintContext.cpp View 9 chunks +49 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/page/PrintContextTest.cpp View 6 chunks +8 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Lei Zhang
3 years, 7 months ago (2017-05-05 23:54:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
85199fb739f0c8b8e491cd6f1ac538efb4134ad0.

Powered by Google App Engine
This is Rietveld 408576698