Don't ReleaseCodecAndBundle in AVDA::ActualDestroy.

Don't ReleaseCodecAndBundle in AVDA::ActualDestroy.

Previously, we were releasing the codec and surface bundle when
destroying AVDA.  However, if async codec allocation was in
progress, then this would modify |codec_config_|.  Even if
no race condition was present, codec allocation would fail
when it tried to dereference the surface bundle.

This CL changes ActualDestroy to ReleaseCodec only.  The surface
bundle will be freed when the surface bundle is dropped during
AVDA destruction (or when async codec allocation completes).

BUG=718865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2864683002
Cr-Commit-Position: refs/heads/master@{#469833}
Committed: https://chromium.googlesource.com/chromium/src/+/02ea6568c0b73b6c9873ea2f3aef44d77dc81a25

[liberato (no reviews please), 2017-05-05 18:28:20]

Description was changed from

==========
Don't ReleaseCodecAndBundle in AVDA::ActualDestroy.

Previously, we were releasing the codec and surface bundle when
destroying AVDA.  However, if async codec allocation was in
progress, then this would modify |codec_config_|.  Even if
no race condition was present, codec allocation would fail
when it tried to dereference the surface bundle.

This CL changes ActualDestroy to ReleaseCodec only.  The surface
bundle will be freed when the surface bundle is dropped during
AVDA destruction (or when async codec allocation completes).

BUG=718865
==========

to

==========
Don't ReleaseCodecAndBundle in AVDA::ActualDestroy.

Previously, we were releasing the codec and surface bundle when
destroying AVDA.  However, if async codec allocation was in
progress, then this would modify |codec_config_|.  Even if
no race condition was present, codec allocation would fail
when it tried to dereference the surface bundle.

This CL changes ActualDestroy to ReleaseCodec only.  The surface
bundle will be freed when the surface bundle is dropped during
AVDA destruction (or when async codec allocation completes).

BUG=718865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[liberato (no reviews please), 2017-05-05 18:28:46]

The CQ bit was checked by liberato@chromium.org to run a CQ dry run

[liberato (no reviews please), 2017-05-05 18:28:50]

Description was changed from

==========
Don't ReleaseCodecAndBundle in AVDA::ActualDestroy.

Previously, we were releasing the codec and surface bundle when
destroying AVDA.  However, if async codec allocation was in
progress, then this would modify |codec_config_|.  Even if
no race condition was present, codec allocation would fail
when it tried to dereference the surface bundle.

This CL changes ActualDestroy to ReleaseCodec only.  The surface
bundle will be freed when the surface bundle is dropped during
AVDA destruction (or when async codec allocation completes).

BUG=718865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Don't ReleaseCodecAndBundle in AVDA::ActualDestroy.

Previously, we were releasing the codec and surface bundle when
destroying AVDA.  However, if async codec allocation was in
progress, then this would modify |codec_config_|.  Even if
no race condition was present, codec allocation would fail
when it tried to dereference the surface bundle.

This CL changes ActualDestroy to ReleaseCodec only.  The surface
bundle will be freed when the surface bundle is dropped during
AVDA destruction (or when async codec allocation completes).

BUG=718865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[liberato (no reviews please), 2017-05-05 18:28:50]

liberato@chromium.org changed reviewers:
+ watk@chromium.org

[commit-bot: I haz the power, 2017-05-05 18:29:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[liberato (no reviews please), 2017-05-05 18:29:39]

hopefully, this prevents the crashes that started happening in AVDA recently due
to my earlier changes.

thanks
-fl

[watk, 2017-05-05 18:52:03]

lgtm

Classic case of an error prone interface I would say. I have plans to improve
this by making CodecConfig immutable (at least by MCVD) and having
AVDACodecAllocator attaching it to the codec it returns.

[commit-bot: I haz the power, 2017-05-05 21:13:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 21:13:22]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[liberato (no reviews please), 2017-05-05 21:19:05]

The CQ bit was checked by liberato@chromium.org

[commit-bot: I haz the power, 2017-05-05 21:20:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-06 00:50:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494019145109220, "parent_rev":
"56de014ae2e5f80d5a009401d8d513314b3b5a6d", "commit_rev":
"02ea6568c0b73b6c9873ea2f3aef44d77dc81a25"}

[commit-bot: I haz the power, 2017-05-06 00:50:48]

Description was changed from

==========
Don't ReleaseCodecAndBundle in AVDA::ActualDestroy.

Previously, we were releasing the codec and surface bundle when
destroying AVDA.  However, if async codec allocation was in
progress, then this would modify |codec_config_|.  Even if
no race condition was present, codec allocation would fail
when it tried to dereference the surface bundle.

This CL changes ActualDestroy to ReleaseCodec only.  The surface
bundle will be freed when the surface bundle is dropped during
AVDA destruction (or when async codec allocation completes).

BUG=718865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Don't ReleaseCodecAndBundle in AVDA::ActualDestroy.

Previously, we were releasing the codec and surface bundle when
destroying AVDA.  However, if async codec allocation was in
progress, then this would modify |codec_config_|.  Even if
no race condition was present, codec allocation would fail
when it tried to dereference the surface bundle.

This CL changes ActualDestroy to ReleaseCodec only.  The surface
bundle will be freed when the surface bundle is dropped during
AVDA destruction (or when async codec allocation completes).

BUG=718865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2864683002
Cr-Commit-Position: refs/heads/master@{#469833}
Committed:
https://chromium.googlesource.com/chromium/src/+/02ea6568c0b73b6c9873ea2f3aef...
==========

[commit-bot: I haz the power, 2017-05-06 00:50:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/02ea6568c0b73b6c9873ea2f3aef...