Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2864643002: Support tracing metrics for measureValueAsync method (Closed)

Created:
3 years, 7 months ago by nednguyen
Modified:
3 years, 7 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, blink-reviews, telemetry-reviews_chromium.org, dmurph, charliea (OOO until 10-5)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Support tracing metrics for measureValueAsync method This exposes PerfTestRunner.addRunTestStartMarker & PerfTestRunner.addRunTestEndMarker so that async perf tests can add their own markers to get trace metrics. An example of how this works is shown in third_party/WebKit/PerformanceTests/TestData/simple-blob-measure-async.html. BUG=701059 Review-Url: https://codereview.chromium.org/2864643002 Cr-Commit-Position: refs/heads/master@{#469708} Committed: https://chromium.googlesource.com/chromium/src/+/3262dfe6856cc6dc9a1e9260635b34572a0256e3

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address Wang Xianzhu's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -19 lines) Patch
M third_party/WebKit/PerformanceTests/TestData/append-child-measure-time.html View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/PerformanceTests/TestData/simple-blob-measure-async.html View 1 1 chunk +52 lines, -0 lines 0 comments Download
M third_party/WebKit/PerformanceTests/resources/runner.js View 3 chunks +8 lines, -8 lines 0 comments Download
M tools/perf/benchmarks/blink_perf.py View 5 chunks +13 lines, -6 lines 0 comments Download
M tools/perf/benchmarks/blink_perf_unittest.py View 5 chunks +74 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
nednguyen
https://codereview.chromium.org/2864643002/diff/1/tools/perf/benchmarks/blink_perf.py File tools/perf/benchmarks/blink_perf.py (right): https://codereview.chromium.org/2864643002/diff/1/tools/perf/benchmarks/blink_perf.py#newcode113 tools/perf/benchmarks/blink_perf.py:113: # that have duplicated uuid. Daniel: I found about ...
3 years, 7 months ago (2017-05-05 15:11:26 UTC) #3
Xianzhu
lgtm https://codereview.chromium.org/2864643002/diff/1/third_party/WebKit/PerformanceTests/TestData/simple-blob-measure-async.html File third_party/WebKit/PerformanceTests/TestData/simple-blob-measure-async.html (right): https://codereview.chromium.org/2864643002/diff/1/third_party/WebKit/PerformanceTests/TestData/simple-blob-measure-async.html#newcode42 third_party/WebKit/PerformanceTests/TestData/simple-blob-measure-async.html:42: done: function() { This is duplicate with line ...
3 years, 7 months ago (2017-05-05 15:29:16 UTC) #5
nednguyen
https://codereview.chromium.org/2864643002/diff/1/third_party/WebKit/PerformanceTests/TestData/simple-blob-measure-async.html File third_party/WebKit/PerformanceTests/TestData/simple-blob-measure-async.html (right): https://codereview.chromium.org/2864643002/diff/1/third_party/WebKit/PerformanceTests/TestData/simple-blob-measure-async.html#newcode42 third_party/WebKit/PerformanceTests/TestData/simple-blob-measure-async.html:42: done: function() { On 2017/05/05 15:29:15, Xianzhu wrote: > ...
3 years, 7 months ago (2017-05-05 15:34:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864643002/20001
3 years, 7 months ago (2017-05-05 15:35:59 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 17:43:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3262dfe6856cc6dc9a1e9260635b...

Powered by Google App Engine
This is Rietveld 408576698