Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2864613004: Prune ComputeVisibleSelectionInDOMTreeDeprecated from IsCaretAtStartOfWrappedLine (Closed)

Created:
3 years, 7 months ago by Xiaocheng
Modified:
3 years, 7 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune ComputeVisibleSelectionInDOMTreeDeprecated from IsCaretAtStartOfWrappedLine This patch prunes the deprecated function from IsCaretAtStartOfWrappedLine. The change is safe because layout is always clean at the call site, which is updated in Editor::HandleTextEvnet(). BUG=698633 TEST=n/a; no behavioral changes Review-Url: https://codereview.chromium.org/2864613004 Cr-Commit-Position: refs/heads/master@{#469950} Committed: https://chromium.googlesource.com/chromium/src/+/74d738716697dfef5c4d124bdaad3b3c06a8bbe9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Xiaocheng
PTAL.
3 years, 7 months ago (2017-05-08 02:47:52 UTC) #7
yosin_UTC9
lgtm
3 years, 7 months ago (2017-05-08 03:35:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864613004/1
3 years, 7 months ago (2017-05-08 03:35:28 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/364631) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 7 months ago (2017-05-08 04:55:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864613004/1
3 years, 7 months ago (2017-05-08 06:56:18 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 10:30:57 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/74d738716697dfef5c4d124bdaad...

Powered by Google App Engine
This is Rietveld 408576698