Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 2864603007: Revert of AppShell: pass command-line files to app as launch data (Closed)

Created:
3 years, 7 months ago by michaelpg
Modified:
3 years, 7 months ago
Reviewers:
rkc, benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of AppShell: pass command-line files to app as launch data (patchset #3 id:40001 of https://codereview.chromium.org/2824553002/ ) Reason for revert: TBR was insufficient for commit Original issue's description: > AppShell: pass command-line files to app as launch data > > An app that registers file handlers can be passed filenames on the > command line to use those files. > > BUG=679870 > TBR=benwells@chromium.org # DEPS > > Review-Url: https://codereview.chromium.org/2824553002 > Cr-Commit-Position: refs/heads/master@{#469827} > Committed: https://chromium.googlesource.com/chromium/src/+/b7b29db1011a7b8e0e8816449e2209305402a46a TBR=rkc@chromium.org,benwells@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=679870 Review-Url: https://codereview.chromium.org/2864603007 Cr-Commit-Position: refs/heads/master@{#469893} Committed: https://chromium.googlesource.com/chromium/src/+/5734f6c060a77bb7ba0c67342a43064f555d3c41

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -15 lines) Patch
M extensions/shell/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/shell/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/shell/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/shell/browser/default_shell_browser_main_delegate.cc View 2 chunks +8 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
michaelpg
Created Revert of AppShell: pass command-line files to app as launch data
3 years, 7 months ago (2017-05-06 23:43:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864603007/1
3 years, 7 months ago (2017-05-06 23:43:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5734f6c060a77bb7ba0c67342a43064f555d3c41
3 years, 7 months ago (2017-05-06 23:43:52 UTC) #7
michaelpg
3 years, 7 months ago (2017-05-06 23:45:03 UTC) #8
Message was sent while issue was closed.
On 2017/05/06 23:43:52, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/5734f6c060a77bb7ba0c67342a43...

Dang it, I didn't want to bypass the CQ. It should be fine, but I'll keep an eye
on the tree. >_<

Powered by Google App Engine
This is Rietveld 408576698