Implement and ship PushSubscription.expirationTime

third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp

Index: third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp
diff --git a/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp b/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp
index e6a113239c1644380a4f82232d2debc3e50f7039..2bcaed85f4ab8813d8b4bd8ce6eea2a826ed0962 100644
--- a/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp
+++ b/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp
@@ -46,6 +46,15 @@ PushSubscription::PushSubscription(
 
 PushSubscription::~PushSubscription() {}
 
+DOMTimeStamp PushSubscription::expirationTime(bool& is_null) const {

[jochen (gone - plz use gerrit), 2017/05/05 14:35:42]

why not bool*?

[Peter Beverloo, 2017/05/05 14:42:55]

WebKit was very much about references as opposed to pointers, so this is how I
implemented nullable values many many years ago. That seems to have survived the
various rewrites our bindings code has gone through over the years :).

+  // This attribute reflects the time at which the subscription will expire,
+  // which is not relevant to this implementation yet as subscription refreshes
+  // are not supported.
+  is_null = true;
+
+  return 0;
+}
+
 DOMArrayBuffer* PushSubscription::getKey(const AtomicString& name) const {
   if (name == "p256dh")
     return p256dh_;
@@ -73,6 +82,7 @@ ScriptValue PushSubscription::toJSONForBinding(ScriptState* script_state) {
 
   V8ObjectBuilder result(script_state);
   result.AddString("endpoint", endpoint());
+  result.AddNull("expirationTime");
 
   V8ObjectBuilder keys(script_state);
   keys.Add("p256dh",