Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2864523002: Rename ScopedComPtr::QueryInterface to ScopedComPtr::CopyTo (Closed)

Created:
3 years, 7 months ago by robliao
Modified:
3 years, 7 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, mfoltz+watch_chromium.org, miu+watch_chromium.org, cbentzel+watch_chromium.org, aboxhall+watch_chromium.org, grt+watch_chromium.org, chromoting-reviews_chromium.org, jam, net-reviews_chromium.org, je_julie, darin-cc_chromium.org, xjz+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, piman+watch_chromium.org, wfh+watch_chromium.org, nektar+watch_chromium.org, dtseng+watch_chromium.org, tfarina, danakj+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ScopedComPtr::QueryInterface to ScopedComPtr::CopyTo This renames QueryInterface() to CopyTo() to harmonize with ComPtr::CopyTo(). Most replacements were performed automatically with clang-tidy. BUG=638327 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=dalecurtis@chromium.org, jam@chromium.org, kbr@chromium.org, rsleevi@chromium.org, thakis@chromium.org, wez@chromium.org Mechanical rename. Review-Url: https://codereview.chromium.org/2864523002 Cr-Commit-Position: refs/heads/master@{#469639} Committed: https://chromium.googlesource.com/chromium/src/+/ca3a3abe11f55102dbfa923c0d14abed5e2f6b72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -75 lines) Patch
M base/win/scoped_comptr.h View 3 chunks +3 lines, -3 lines 0 comments Download
M base/win/scoped_comptr_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_update_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/win/jumplist_updater.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/accessibility/accessibility_event_recorder_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/accessibility_win_browsertest.cc View 10 chunks +11 lines, -11 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win_unittest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M gpu/ipc/service/direct_composition_surface_win.cc View 10 chunks +14 lines, -14 lines 0 comments Download
M media/capture/video/win/video_capture_device_factory_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/win/video_capture_device_win.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M media/gpu/d3d11_video_decode_accelerator_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/gpu/media_foundation_video_encode_accelerator_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/rdp_client_window.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/font_fallback_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/win/direct_write.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_angle_util_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_win_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
robliao
scottmg: Please review this CL. Thanks!
3 years, 7 months ago (2017-05-04 21:14:50 UTC) #6
scottmg
lgtm
3 years, 7 months ago (2017-05-04 21:32:21 UTC) #7
robliao
TBR'ing top-level directory owners for this mechanical rename. Owners: dalecurtis: media/* jam: content/* kbr: gpu/* ...
3 years, 7 months ago (2017-05-05 13:58:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864523002/1
3 years, 7 months ago (2017-05-05 13:59:23 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 14:04:18 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ca3a3abe11f55102dbfa923c0d14...

Powered by Google App Engine
This is Rietveld 408576698