Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2864493005:
Accessibility Object Model: remove reflection (Closed)
|
Created:
3 years, 7 months ago by dmazzoni Modified:
3 years, 7 months ago CC:
aboxhall+watch_chromium.org, aboxhall, blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, dmazzoni, dmazzoni+watch_chromium.org, dougt+watch_chromium.org, dtseng+watch_chromium.org, eae+blinkwatch, haraken, je_julie, nektar+watch_chromium.org, nektarios, rwlbuis, sof, yuzo+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAccessibility Object Model: remove reflection
Based on the latest consensus
(https://github.com/WICG/aom/pull/75),
AOM properties override ARIA attributes,
with no reflection.
BUG=680345
Review-Url: https://codereview.chromium.org/2864493005
Cr-Commit-Position: refs/heads/master@{#470513}
Committed: https://chromium.googlesource.com/chromium/src/+/c140ef12a0591bc5b770c97b1b23d6c83a49fb20
Patch Set 1 #Patch Set 2 : Rebase #
Messages
Total messages: 30 (19 generated)
The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Description was changed from ========== AOM: no reflection BUG= ========== to ========== Accessibility Object Model: remove reflection Based on the latest consensus (https://github.com/WICG/aom/pull/75), AOM properties override ARIA attributes, with no reflection. BUG=680345 ==========
dmazzoni@chromium.org changed reviewers: + aboxhall@chromium.org
lgtm
dmazzoni@chromium.org changed reviewers: + mkwst@chromium.org
+mkwst - would you be willing to help with owners review for core/?
LGTM.
The CQ bit was checked by dmazzoni@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by dmazzoni@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org, aboxhall@chromium.org Link to the patchset: https://codereview.chromium.org/2864493005/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by dmazzoni@chromium.org
The CQ bit was unchecked by dmazzoni@chromium.org
The CQ bit was checked by dmazzoni@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by dmazzoni@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494394801688680,
"parent_rev": "39c34e94e02aa327f7f08b888f1d0949cb940a9c", "commit_rev":
"c140ef12a0591bc5b770c97b1b23d6c83a49fb20"}
Message was sent while issue was closed.
Description was changed from ========== Accessibility Object Model: remove reflection Based on the latest consensus (https://github.com/WICG/aom/pull/75), AOM properties override ARIA attributes, with no reflection. BUG=680345 ========== to ========== Accessibility Object Model: remove reflection Based on the latest consensus (https://github.com/WICG/aom/pull/75), AOM properties override ARIA attributes, with no reflection. BUG=680345 Review-Url: https://codereview.chromium.org/2864493005 Cr-Commit-Position: refs/heads/master@{#470513} Committed: https://chromium.googlesource.com/chromium/src/+/c140ef12a0591bc5b770c97b1b23... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/c140ef12a0591bc5b770c97b1b23... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
