components/password_manager/core/browser/credential_manager_logger_unittest.cc - Issue 2864493003: Deprecate CredentialRequestOptions.unmediated in favor mediation enum

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/credential_manager_logger_unittest.cc

Issue 2864493003: Deprecate CredentialRequestOptions.unmediated in favor mediation enum (Closed)

Patch Set: Fix Windows Compilation Error Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/credential_manager_logger.cc ('K') | « components/password_manager/core/browser/credential_manager_logger.cc ('k') | components/password_manager/core/browser/credential_manager_pending_request_task.h » ('j') | components/password_manager/core/browser/credential_manager_pending_request_task.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/credential_manager_logger_unittest.cc

diff --git a/components/password_manager/core/browser/credential_manager_logger_unittest.cc b/components/password_manager/core/browser/credential_manager_logger_unittest.cc

index af6a98faba50b986812c83faa09198314ceb8226..f0cbdbc41c83e1272b35fb102862d991cd3b8516 100644

--- a/components/password_manager/core/browser/credential_manager_logger_unittest.cc

+++ b/components/password_manager/core/browser/credential_manager_logger_unittest.cc

@@ -53,7 +53,8 @@ TEST_F(CredentialManagerLoggerTest, LogRequestCredential) {

EXPECT_CALL(log_manager(),

LogSavePasswordProgress(

AllOf(HasSubstr(kSiteOrigin), HasSubstr(kFederationOrigin))));

- logger().LogRequestCredential(GURL(kSiteOrigin), true,

+ logger().LogRequestCredential(GURL(kSiteOrigin),

+ CredentialMediationRequirement::SILENT,

{GURL(kFederationOrigin)});

}