Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: components/password_manager/core/browser/credential_manager_logger.cc

Issue 2864493003: Deprecate CredentialRequestOptions.unmediated in favor mediation enum (Closed)
Patch Set: Fix Windows Compilation Error Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/credential_manager_logger.cc
diff --git a/components/password_manager/core/browser/credential_manager_logger.cc b/components/password_manager/core/browser/credential_manager_logger.cc
index f5173c1868ac341eb453e20430e270c91eca7225..a407ace5b2ad3eb1cf76f4487348a986d0c5912a 100644
--- a/components/password_manager/core/browser/credential_manager_logger.cc
+++ b/components/password_manager/core/browser/credential_manager_logger.cc
@@ -21,11 +21,19 @@ CredentialManagerLogger::~CredentialManagerLogger() = default;
void CredentialManagerLogger::LogRequestCredential(
const GURL& url,
- bool zero_click_only,
+ CredentialMediationRequirement mediation,
const std::vector<GURL>& federations) {
std::string s("CM API get credentials: origin=" +
SavePasswordProgressLogger::ScrubURL(url));
- s += ", zero_click_only=" + base::IntToString(zero_click_only);
+ s += ", mediation=";
+ switch (mediation) {
+ case CredentialMediationRequirement::SILENT:
+ s += "silent";
vasilii 2017/05/18 12:34:03 What about breaks?
jdoerrie 2017/05/18 14:57:24 Done.
+ case CredentialMediationRequirement::OPTIONAL:
+ s += "optional";
+ case CredentialMediationRequirement::REQUIRED:
+ s += "required";
+ }
s += ", federations=";
for (const GURL& federation_provider : federations)
s += SavePasswordProgressLogger::ScrubURL(federation_provider) + ", ";

Powered by Google App Engine
This is Rietveld 408576698