Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2864493002: Mark SSLUITest.TestOKHTTPS as not flaky (Closed)

Created:
3 years, 7 months ago by meacer
Modified:
3 years, 7 months ago
Reviewers:
felt
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark SSLUITest.TestOKHTTPS as not flaky The flakes are from 2011 and don't seem to be happening anymore. De-flake the test. BUG=91684 Review-Url: https://codereview.chromium.org/2864493002 Cr-Commit-Position: refs/heads/master@{#469440} Committed: https://chromium.googlesource.com/chromium/src/+/aa9441554789076b22883c464586db1e728423ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M chrome/browser/ssl/ssl_browser_tests.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
meacer
PTAL?
3 years, 7 months ago (2017-05-04 18:47:37 UTC) #5
felt
lgtm please keep an eye on the dash for a few days
3 years, 7 months ago (2017-05-04 19:55:46 UTC) #8
meacer
On 2017/05/04 19:55:46, felt wrote: > lgtm > > please keep an eye on the ...
3 years, 7 months ago (2017-05-04 19:59:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864493002/1
3 years, 7 months ago (2017-05-04 19:59:44 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 20:05:53 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aa9441554789076b22883c464586...

Powered by Google App Engine
This is Rietveld 408576698