Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2864483006: [MD settings] prevent paper-buttons from shrinking (Closed)

Created:
3 years, 7 months ago by dschuyler
Modified:
3 years, 7 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] prevent paper-buttons from shrinking This CL prevents flex pressure from squeezing paper-buttons. E.g. prevent a long account name from making the "sign in to chrome" button into a column of text. BUG=718318 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2864483006 Cr-Commit-Position: refs/heads/master@{#469502} Committed: https://chromium.googlesource.com/chromium/src/+/8d06f045c53f2f42420e6ca4d57d3c608f529c9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/settings/settings_shared_css.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dschuyler
There are other ways from preventing the text from wrapping, but I think we want ...
3 years, 7 months ago (2017-05-04 21:19:03 UTC) #5
stevenjb
lgtm
3 years, 7 months ago (2017-05-04 21:20:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864483006/1
3 years, 7 months ago (2017-05-04 22:45:18 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 22:55:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8d06f045c53f2f42420e6ca4d57d...

Powered by Google App Engine
This is Rietveld 408576698