Add more common errors to JUnit4 documentation

Add more common errors to JUnit4 documentation

BUG=640116
Review-Url: https://codereview.chromium.org/2864483004
Cr-Commit-Position: refs/heads/master@{#469491}
Committed: https://chromium.googlesource.com/chromium/src/+/6abba8e52ba13f660d2350b08f3d1829ce282edd

[the real yoland, 2017-05-04 19:29:12]

yolandyan@chromium.org changed reviewers:
+ jbudorick@chromium.org, mikecase@chromium.org, tedchoc@chromium.org

[the real yoland, 2017-05-04 19:31:10]

So many issues with @UiThreadTest, we should have our own @UiThreadOnTestMethod
that is supported by default.

[jbudorick, 2017-05-04 19:40:47]

https://codereview.chromium.org/2864483004/diff/1/testing/android/docs/junit4.md
File testing/android/docs/junit4.md (right):

https://codereview.chromium.org/2864483004/diff/1/testing/android/docs/junit4...
testing/android/docs/junit4.md:157: java.lang.IllegalStateException: The current
thread must have a looper!
I think you need an extra blank line before this one.

https://codereview.chromium.org/2864483004/diff/1/testing/android/docs/junit4...
testing/android/docs/junit4.md:224: 1.  Error-prone warning when disabling a
javatest in JUnit4. If you get a
Rephrase:

 1. Errorprone expects all methods starting with `test...` to be annotated with
`@Test`. Failure to meet that expectation will cause errorprone to fail with
something like this:

  `[JUnit4TestNotRun] ...`

  In particular, you may see this when attempting to disable tests. In that
case, the test should be annotated with both @DisabledTest and @Test.

[the real yoland, 2017-05-04 19:53:29]

Changes also reflected in viewing link

https://codereview.chromium.org/2864483004/diff/1/testing/android/docs/junit4.md
File testing/android/docs/junit4.md (right):

https://codereview.chromium.org/2864483004/diff/1/testing/android/docs/junit4...
testing/android/docs/junit4.md:157: java.lang.IllegalStateException: The current
thread must have a looper!
On 2017/05/04 at 19:40:47, jbudorick wrote:
> I think you need an extra blank line before this one.

Done

https://codereview.chromium.org/2864483004/diff/1/testing/android/docs/junit4...
testing/android/docs/junit4.md:224: 1.  Error-prone warning when disabling a
javatest in JUnit4. If you get a
On 2017/05/04 at 19:40:47, jbudorick wrote:
> Rephrase:
> 
>  1. Errorprone expects all methods starting with `test...` to be annotated
with `@Test`. Failure to meet that expectation will cause errorprone to fail
with something like this:
> 
>   `[JUnit4TestNotRun] ...`
> 
>   In particular, you may see this when attempting to disable tests. In that
case, the test should be annotated with both @DisabledTest and @Test.

Done

[mikecase (-- gone --), 2017-05-04 21:52:54]

non-owner lgtm

[jbudorick, 2017-05-04 21:56:15]

On 2017/05/04 21:52:54, mikecase wrote:
> non-owner lgtm

lgtm

[the real yoland, 2017-05-04 22:06:39]

The CQ bit was checked by yolandyan@chromium.org

[commit-bot: I haz the power, 2017-05-04 22:07:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 22:19:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493935599336450,
"parent_rev": "5be7c3c145790e7c762f8ab371d3ea5d2673b337", "commit_rev":
"6abba8e52ba13f660d2350b08f3d1829ce282edd"}

[commit-bot: I haz the power, 2017-05-04 22:20:07]

Description was changed from

==========
Add more common errors to JUnit4 documentation

BUG=640116
==========

to

==========
Add more common errors to JUnit4 documentation

BUG=640116

Review-Url: https://codereview.chromium.org/2864483004
Cr-Commit-Position: refs/heads/master@{#469491}
Committed:
https://chromium.googlesource.com/chromium/src/+/6abba8e52ba13f660d2350b08f3d...
==========

[commit-bot: I haz the power, 2017-05-04 22:20:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6abba8e52ba13f660d2350b08f3d...