Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1328)

Issue 2864463004: [ic] Restore Function.prototype fast path for LoadIC_Uninitialized (Closed)

Created:
3 years, 7 months ago by Jakob Kummerow
Modified:
3 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Restore Function.prototype fast path for LoadIC_Uninitialized It was replaced by more generic handling in 1320666798d, which is functionally fine, but for performance it makes sense to keep the fast path. Review-Url: https://codereview.chromium.org/2864463004 Cr-Commit-Position: refs/heads/master@{#45155} Committed: https://chromium.googlesource.com/v8/v8/+/d2ba280d47bf6250aca27b1997c28dce3d0d2963

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M src/ic/accessor-assembler.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Jakob Kummerow
PTAL.
3 years, 7 months ago (2017-05-05 15:29:57 UTC) #2
Benedikt Meurer
LGTM
3 years, 7 months ago (2017-05-06 04:12:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864463004/1
3 years, 7 months ago (2017-05-08 08:58:28 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 09:27:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d2ba280d47bf6250aca27b1997c28dce3d0...

Powered by Google App Engine
This is Rietveld 408576698