Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: tests/standalone/io/socket_exception_test.dart

Issue 2864443002: Revert "Throw when adding something to a closed sink and improve documentation." (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/io/socket_exception_test.dart
diff --git a/tests/standalone/io/socket_exception_test.dart b/tests/standalone/io/socket_exception_test.dart
index 364acccbb954a5ff2fcd591e7d52c1ff6edd88b7..3dbe93eb1cd5549e2b93dbcb13ccc207bc1e658a 100644
--- a/tests/standalone/io/socket_exception_test.dart
+++ b/tests/standalone/io/socket_exception_test.dart
@@ -90,8 +90,6 @@ class SocketExceptionTest {
}
Expect.isFalse(exceptionCaught);
Expect.isFalse(wrongExceptionCaught);
-
- // From here exceptions are expected.
try {
List<int> buffer = new List<int>(10);
client.add(buffer);
@@ -100,8 +98,10 @@ class SocketExceptionTest {
} catch (ex) {
wrongExceptionCaught = true;
}
- Expect.isTrue(exceptionCaught);
+ Expect.isFalse(exceptionCaught);
Expect.isFalse(wrongExceptionCaught);
+
+ // From here exceptions are expected.
exceptionCaught = false;
try {
client.port;
« no previous file with comments | « tests/standalone/io/http_content_length_test.dart ('k') | tests/standalone/io/socket_upgrade_to_secure_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698