Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: tests/standalone/io/socket_upgrade_to_secure_test.dart

Issue 2864443002: Revert "Throw when adding something to a closed sink and improve documentation." (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/socket_exception_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/socket_upgrade_to_secure_test.dart
diff --git a/tests/standalone/io/socket_upgrade_to_secure_test.dart b/tests/standalone/io/socket_upgrade_to_secure_test.dart
index 5b58b56467c10c882336b3db5fafeb5342472bed..84b67be5d4aec29d14277790cf3372710bfc3a61 100644
--- a/tests/standalone/io/socket_upgrade_to_secure_test.dart
+++ b/tests/standalone/io/socket_upgrade_to_secure_test.dart
@@ -164,9 +164,7 @@ void test(bool hostnameInConnect, bool handshakeBeforeSecure,
SecureSocket.secure(socket, host: HOST, context: clientContext);
}
return future.then((secureSocket) {
- Expect.throws(() {
- socket.add([0]);
- });
+ socket.add([0]);
return secureSocket;
});
});
@@ -181,9 +179,7 @@ void test(bool hostnameInConnect, bool handshakeBeforeSecure,
SecureSocket.secure(socket, host: HOST, context: clientContext);
}
return future.then((secureSocket) {
- Expect.throws(() {
- socket.add([0]);
- });
+ socket.add([0]);
return secureSocket;
});
});
@@ -195,9 +191,7 @@ void test(bool hostnameInConnect, bool handshakeBeforeSecure,
server.listen((client) {
if (!handshakeBeforeSecure) {
SecureSocket.secureServer(client, serverContext).then((secureClient) {
- Expect.throws(() {
- client.add([0]);
- });
+ client.add([0]);
runServer(secureClient).then((_) => server.close());
});
} else {
@@ -205,9 +199,7 @@ void test(bool hostnameInConnect, bool handshakeBeforeSecure,
SecureSocket
.secureServer(client, serverContext, bufferedData: carryOverData)
.then((secureClient) {
- Expect.throws(() {
- client.add([0]);
- });
+ client.add([0]);
runServer(secureClient).then((_) => server.close());
});
});
« no previous file with comments | « tests/standalone/io/socket_exception_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698