Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2864443002: Revert "Throw when adding something to a closed sink and improve documentation." (Closed)

Created:
3 years, 7 months ago by floitsch
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Throw when adding something to a closed sink and improve documentation." This reverts commit 8e19729b8913c4225ef84e863193e36879947727. BUG= Committed: https://github.com/dart-lang/sdk/commit/8f3ae7e7e13fad563a84227fa78c6e520d956566

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -113 lines) Patch
M CHANGELOG.md View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/async/stream.dart View 3 chunks +11 lines, -27 lines 0 comments Download
M sdk/lib/async/stream_controller.dart View 1 chunk +1 line, -30 lines 0 comments Download
M sdk/lib/async/stream_transformers.dart View 3 chunks +4 lines, -15 lines 0 comments Download
M sdk/lib/core/sink.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/io/io_sink.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/io/secure_socket.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/standalone/io/file_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M tests/standalone/io/http_10_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M tests/standalone/io/http_content_length_test.dart View 3 chunks +3 lines, -9 lines 0 comments Download
M tests/standalone/io/socket_exception_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/socket_upgrade_to_secure_test.dart View 4 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
floitsch
TBR.
3 years, 7 months ago (2017-05-04 10:52:52 UTC) #2
floitsch
3 years, 7 months ago (2017-05-04 10:52:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8f3ae7e7e13fad563a84227fa78c6e520d956566 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698