Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 2864433002: [MD Bookmarks] Add hover border to sidebar splitter. (Closed)

Created:
3 years, 7 months ago by calamity
Modified:
3 years, 7 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Bookmarks] Add hover border to sidebar splitter. This CL adds a thin left border to the sidebar splitter so that users can discover it more easily. This also required a change to the splitter that was not taking into account the width of a scrollbar when determining the starting width for a drag. BUG=716234 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2864433002 Cr-Commit-Position: refs/heads/master@{#469927} Committed: https://chromium.googlesource.com/chromium/src/+/adf8886b489461915a26a3e2d70d106e63c232d2

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M chrome/browser/resources/md_bookmarks/app.html View 1 1 chunk +9 lines, -0 lines 0 comments Download
M ui/webui/resources/js/cr/ui/splitter.js View 1 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
calamity
3 years, 7 months ago (2017-05-04 08:38:34 UTC) #3
tsergeant
Is it possible to make it so that the hover state is always shown while ...
3 years, 7 months ago (2017-05-05 00:36:22 UTC) #4
calamity
https://codereview.chromium.org/2864433002/diff/1/chrome/browser/resources/md_bookmarks/app.html File chrome/browser/resources/md_bookmarks/app.html (right): https://codereview.chromium.org/2864433002/diff/1/chrome/browser/resources/md_bookmarks/app.html#newcode40 chrome/browser/resources/md_bookmarks/app.html:40: border-left: 1px solid rgba(0, 0, 0, 0.1); On 2017/05/05 ...
3 years, 7 months ago (2017-05-05 05:09:55 UTC) #5
tsergeant
lgtm
3 years, 7 months ago (2017-05-05 05:33:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864433002/20001
3 years, 7 months ago (2017-05-08 03:28:43 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/420360)
3 years, 7 months ago (2017-05-08 04:56:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864433002/20001
3 years, 7 months ago (2017-05-08 07:03:48 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 08:52:24 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/adf8886b489461915a26a3e2d70d...

Powered by Google App Engine
This is Rietveld 408576698